97656 - Call to NPP_SetWindow in plugins has incorrect window frame

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[John Kinder]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.3+)
Gecko/20010830
BuildID:    2001083005

PDFViewer overwrites the fizilla Navigation and personal toolbars, because the
window frame passed to NPP_SetWindow has it's topleft coordinates at {0,0}
instead of being offset to the correct port origin.  This does not happen in the
classic version of mozilla.

Reproducible: Always
Steps to Reproduce:
1. install PDFViewer in Mozilla plug-ins folder (Contact me for experimental
carbonized PDFViewer plugin for
Acrobat.)
2. open any pdf file


Actual Results:  Acrobat PDFViewer draws its window over the Navigation and
personal toolbars.

Expected Results:  PDFViewer to draw its window in correct location.

Comment 1

[Peter Lubczynski]

My bug. Patch on it's way. After we create the widget, we need to "fix up" the
window before the first SetWindow call. Pretty harmless patch as we do this
every time the timer fires anyway.

Andrei, can you review?

Comment 2

[Peter Lubczynski]

Attachment: simple patch to "fix up" the window right after we create the widget

Comment 3

[av (gone)]

Ah, one more PluginViewer to ObjectFrame standard thing. r=av.

Comment 4

[Marc Attinasi]

sr=attinasi

Comment 5

[Peter Lubczynski]

Just got approval over e-mail from Asa. Thanks Asa! Patch checked in, marking FIXED.

Comment 6

[Peter Lubczynski]

*** Bug 79529 has been marked as a duplicate of this bug. ***

Comment 7

[shrirang khanzode]

verified, got mail confirmation from John too.