976741 - Changing version on GCCrashes chart doesn't seem to work

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2014-02-25 12.59.13.png

Hopefully the screenshot will help explain the problem. 

1. I load https://crash-stats.allizom.org/gccrashes/products/Firefox
2. It loads a nice looking chart and the h1 of the page says "Total Volume of GC Crashes for Firefox 30.0a1"
3. I then change the version drop-down from "30.0a1" to "29.0a2"
4. The h1 still says "Total Volume of GC Crashes for Firefox 30.0a1"
5. The URL of the page doesn't change or contain the version thus making it impossible to share the URL for version 29.0a2.
6. The console (seen in screenshot) seems to indicate there is data but the chart shows "No Data Available"

Comment 1

[Schalk Neethling [:espressive]]

Thanks for logging this Peter. I agree the heading (and page title) needs to change when one changes the version and that the URL needs to be bookmarkable. Regarding the logging seen in the console that seems to indicate that there was data, but none is graphed, that total is actually the time it took to render the graph and is logged by nvd3, see https://github.com/novus/nvd3/blob/master/nv.d3.js#L28

Comment 2

[Schalk Neethling [:espressive]]

Pull request sent: https://github.com/mozilla/socorro/pull/1918

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b8acdad6832860fe8acef9584121f06b06bf27ca
Fix Bug 976741, update relevant items on version change and make url bookmarkable

https://github.com/mozilla/socorro/commit/84fc4cc918bc50d44886843c6a23055817bd2943
Merge pull request #1918 from ossreleasefeed/bug976741-changing-version-does-not-seem-to-work

Fix Bug 976741, update relevant items on version change and make url bookmarkable

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b8acdad6832860fe8acef9584121f06b06bf27ca
Fix Bug 976741, update relevant items on version change and make url bookmarkable

https://github.com/mozilla/socorro/commit/84fc4cc918bc50d44886843c6a23055817bd2943
Merge pull request #1918 from ossreleasefeed/bug976741-changing-version-does-not-seem-to-work

Comment 6

[Schalk Neethling [:espressive]]

QA Steps
--------

There are a couple of items to test here:

1) Load up the GC Crashes page:

https://crash-stats.allizom.org/gccrashes/products/Firefox

After the page has loaded, change the URL to the following

https://crash-stats.allizom.org/gccrashes/products/Firefox/versions/30.0a1

Previously this would have produced an error as described in https://bugzilla.mozilla.org/show_bug.cgi?id=976641, this should no longer happen.

2) Changing the selected version should cause a couple of things to happen:

  -- The window and page title should change to reflect the new version number
  -- The URL should change to reflect the new version

3) In terms of general bookmarkability of the reports, the URL should always change the reflect the currently selected dates, product and version i.e. at any point, you should be able to copy the URL from the address bar, open it up in a new tab and a result should be shown.

4) With regards to the interactivity of the products selector, please refer to https://bugzilla.mozilla.org/show_bug.cgi?id=977256#c12