976937 - Fix usage of Bareword DOM constructors in Gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Bobby Holley (:bholley)]

These will break with bug 916644. The solution is straightforward - we just need to add |new|.

bz found a couple of these on mxr, and I've written a hacky script to grep the gaia tree for all uses of interfaces defined in dom/webidl/* that don't use |new|. Patch coming shortly.

Comment 1

[Bobby Holley (:bholley)]

Attachment: pull request v2

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8383406 [details] [review]
pull request v2

Nothing is in the app I'm the owner of :) Redirecting to the appropriate peers.

- Andrew for E-mail
- Zac for the Python Marionette tests
- Kevin for the Browser Helper

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8383406 [details] [review]
pull request v2

All the files under apps/email/js/ext/ are autogenerated byproducts of gaia-email-libs-and-more and cannot be modified directly.  The actual spots to fix are:

https://github.com/mozilla-b2g/jswbxml/blob/master/wbxml.js#L423

https://github.com/mozilla-b2g/gaia-email-libs-and-more/blob/master/data/lib/node-buffer.js#L106

https://github.com/mozilla-b2g/gaia-email-libs-and-more/blob/master/data/lib/node-buffer.js#L155


Of course, since you are just being a nice person and propagating these changes is a hassle, I'll take care of this now.  This does need to happen in its own commit for tracking/backout/other sanity, however.  So I'm going to r- the patch so it can have these lines taken out.  But I'm going to go file a gaia e-mail bug to block the same bug and fix it all now with r=bholley on it through the shell game of deferring the review to you and then deciding that it counts as a review if the net effect of my changes is exactly what was in your pull request for email.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Andrew Sutherland (:asuth) from comment #3)
> Of course, since you are just being a nice person and propagating these
> changes is a hassle, I'll take care of this now.

Bug 978005 filed, fixed, and landed.  I remembered I could just attribute the patchy bits to :bholley and then I got to be the reviewer, so no shell game.

It turns out that the pop3.js changes are for dead code which I discovered in the process, so bug 978012 was filed in e-mail to remove those and change the installation process to avoid that happening again in the future.  Patch for that going up shortly.

Comment 5

[Zac C (:zac)]

Comment on attachment 8383406 [details] [review]
pull request v2

r+ for my part

Comment 6

[Bobby Holley (:bholley)]

Merged. master: 9a5203ef10724f15599551a41dc28f959aca6037