978012 - [email] Remove dead/obsolete GELAM-built JS blobs and fix GELAM to clean out ext/ before installing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

While addressing bug 978005 (use "new" properly like a boss), I noticed my fixes weren't lining up with the manual transform from bug 976937.

It turns out we have two code zombies:
- apps/email/js/ext/mailapi/composer.js
- apps/email/js/ext/pop3.js

composer.js is my bad from bug 871897; the new blob is mailapi/drafts/composer.js because of some refactoring/moves I did.

It looks like pop3.js was a testing file or intermediary byproduct from development that accidentally got added in the initial commit.  I think I recall :mcav mentioning some hacky build attempts, which would explain some amusing gems in there:

  window.onerror = function (E) {
    dump("EEEEEEEEEEEEEEEEEEEEEEEEEEEE "+ E);
  }

  dump("SEETTING MOSFDJASEOIJEOIWFJWOEFJWIJEIWJ" + this.unprocessedLines[0]);


Anywho, I propose we make gelam rm -rf the 'ext' directory during the install-into-gaia step and then also check in the results.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: gelam Makefile learns to nuke

readlink is different on OS X than linux, so this definitely needs to be run by someone.  (Although it's just "-f" that I think betrays you on OS X, -n should be fine.)

Please also sanity check that I'm right about the pop3.js file.

Thanks.

Comment 2

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8383566 [details] [review]
gelam Makefile learns to nuke

Haha, silly debug messages. Yes, that looks like a mistake; hasn't been touched in 3 months by Gaia. I ran `make install-into-gaia` and it ran fine; I also ran the readlink-remove-ext command individually and confirmed that it properly wiped the files on OS X. Thanks for catching that!

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

landed in gaia-email-libs-and-more/master:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/289
https://github.com/asutherland/gaia/commit/3c392254f2602d8b16f3c5bd27c45e988e1d9f85

landed in gaia/master:
https://github.com/mozilla-b2g/gaia/pull/16793
https://github.com/mozilla-b2g/gaia/commit/560d5353e29b09b5f78b92293d280efb6124f2cf