976960 - [Task Manager] App is disappearing while do opening app from card view.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

STR:
1. Open an app
2. Long press home
3. Click the card

Expected:
The app is opening from task manager

Actual:
The app disappears for a while.

Comment 1

[Jason Smith [:jsmith]]

What do you mean by disappearing?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

It does not appear before the opening transition is ended or near ended.

Comment 3

[Aus Lacroix [:aus]]

Yeah, I'm seeing this too.

Comment 5

[Jason Smith [:jsmith]]

I'm guessing this is a regression from bug 939809.

Comment 6

[Aus Lacroix [:aus]]

Could be. Doesn't really matter to me though, I'm going to have a patch for this real soon regardless. :)

Comment 7

[Aus Lacroix [:aus]]

Pretty easy fix really. We were hiding the card switcher twice. I have a fix but I need to clean it up a little. Will post it to a Pull Request tonight.

Comment 8

[Aus Lacroix [:aus]]

Attachment: Pull Request - Avoid going back to 'homescreen'

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8383503 [details] [review]
Pull Request - Avoid going back to 'homescreen'

r=me with a simple test added (it's too good to let regress ;)).

Just tested and you can mimic a tap on an app easily with something like
```
var evt = new CustomEvent('tap');
var target = document.createElement('div');
target.dataset.position = 1;
target.dispatchEvent(evt);
```

and then check that we don't hide the task switcher just yet, but that a |cardviewclosed| event is dispatched.

Comment 10

[Aus Lacroix [:aus]]

Awesome, thanks etienne! I'll add a test real soon and get this merged. :)

Comment 11

[Aus Lacroix [:aus]]

PR updated with new shiny unit test! Waiting for confirmation that everything is green on Travis.

Comment 12

[Aus Lacroix [:aus]]

All green! With Moar Unit Tests!

Fixed!

Commit: https://github.com/mozilla-b2g/gaia/commit/d818ddf52cea344c36bc71be4070007499ca7348

Comment 13

[Oliver Nelson [:oliverthor]]

Verifying fix on flame 3.0 devices
Results: Apps appear and open as expected when launching from card view.

--------------------------------------------------
Environmental Variables:
Device: Flame 3.0
BuildID: 20150210010523
Gaia: 0cf517083f7eb5fc269e1236edba50534f65e3cd
Gecko: 2cb22c058add
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
--------------------------------------------------
Repro: 8/8