976992 - Add RTSP support to the GStreamer backend

Status: RESOLVED WONTFIX

(Core :: Audio/Video: Playback, defect, P5)

Description

[Alessandro Decina]

As discussed on IRC, here's my rtsp patch :) It adds RTSP support to firefox when --enable-gstreamer is used, and when media.gstreamer.disable-whitelist is set to true (it's false by default). All in all it's a non-invasive patch, works similarly to the b2g implementation and I think it would be cool to have there for XUL/webapprt apps.

The patch is modeled after RTSP support for b2g and does the following things:

- adds a dummy, pass-through protocol to netwerk/protocol/ that is needed to handle dealing with rtsp:// URIs. The protocol does no actual network calls.

- adds a dummy GStreamerMediaResource class that is used to special case RTSP loading in MediaResource::Create

- tweaks GStreamerReader to handle rtsp:// loading directly via gstreamer

- adds a new property, media.gstreamer.disable-whitelist, set to false by default, that when set to true allows all of the above to run and rtsp to play

Comment 1

[Alessandro Decina]

Attachment: rtsp.patch

Comment 2

[Alessandro Decina]

Attachment: rtsp.patch

I split the whitelist part of the initial patch in its own bug (https://bugzilla.mozilla.org/show_bug.cgi?id=977437) and left here only the RTSP specific changes

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8382711 [details] [diff] [review]
rtsp.patch

Review of attachment 8382711 [details] [diff] [review]:
-----------------------------------------------------------------

No, sorry. At this time we really don't want to ship RTSP support in desktop Firefox, and we don't want to carry non trivial amounts of code that we're not shipping.

Comment 4

[Alessandro Decina]

Fair enough. Do we agree that the part I split out in https://bugzilla.mozilla.org/show_bug.cgi?id=977437 is trivial though? :)

Comment 5

[Jean-Yves Avenard [:jya]]

gstreamer is going in bug 1234092