Closed
Bug 977308
Opened 10 years ago
Closed 9 years ago
Pre-tenure frontend and XDR objects
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
3.26 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Anything we allocate in the frontend is going to get held live on the tenured script, so is going to survive a minor GC. We should be able to just switch all of the allocation in the frontend to pre-tenure and assert in JSScript::getObject that all of the attached objects are always tenured.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•9 years ago
|
||
This asserts that all of the script->object references are tenured->tenured (in multiple places), and fixes the one place in the frontend where we appear to be able to create a nursery object. At least the following Try run is entirely green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a7d0415c9ca
Attachment #8582552 -
Flags: review?(sphink)
|
||
Updated•9 years ago
|
Attachment #8582552 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a7d0415c9ca https://hg.mozilla.org/integration/mozilla-inbound/rev/c578789c192e
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c578789c192e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•