977336 - Support action bar "up" for FxAccountStatusActivity

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks adding a window title/action bar to the status activity, and reacting to clicks on it.

This "feels right" for settings/preferences activities, will help us fit in with Fennec settings, and should help users get back to the browser.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: github PR

This builds on the earlier PR (so review that first), and there is also a commit for string change that won't get uplifted.

The title for the status activity is the somewhat counter-intuitive "Sync" because of how it looks when accessed from Fennec Settings.  You click Sync, the title really needs to say Sync.

Tested on a v11 tablet and a v16 (?) phone.

This looks surprisingly good on a phone -- especially the Settings -> Sync transition, and surprisingly bad on a tablet.  We'll have to polish tablet layout, but that can uplift easily.

Comment 2

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/8e70331e9fa4

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: 8e70331e9fa4

[Approval Request Comment]

This is a good candidate for uplift.  It needs to bake for a few days, but we know we want it, and it would be nice to uplift just to m-a rather than all the way to m-b, so opening the approval request early.

Bug caused by (feature/regressing bug #): initial FxA landing.

User impact if declined: Sync settings/status doesn't fit in with rest of Fennec settings.

Testing completed (on m-c, etc.): Tested locally on multiple devices.  Needs to bake for a few days.

Risk to taking this patch (and alternatives if risky): low.

String or IDL/UUID changes made by this patch: none.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8e70331e9fa4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e2a8cbbb1469