974134 - Improved layout for Status activity

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Richard Newman [:rnewman]]

Evaluate feasibility by EOW, lest a replacement bug be created :D

Comment 1

[Richard Newman [:rnewman]]

N.B., ideally adds a "Signed In As" string.

https://www.dropbox.com/s/bbberv6477vjh50/android%20touchup.pdf

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: github PR

This is working well locally. The weird code ordering is due to headers in Part 1 (which I didn't want to change); I'll put the final pre as a post, I think.

I have not tested on devices older than 3.0. I have a 2.3.6 armv6 phone, but it's a pain to build for. I think it makes sense to land, and then address old phones with QA, rather than block landing on a try run and test cycle, but I could be convinced otherwise.

This can be uplifted. Already opened a ticket for action bar/up support (which can be uplifted), and will open a new ticket for the "Signed in as" string.

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/21f64facd467

Comment 4

[Nick Alexander :nalexander [he/him]]

All sorts of QA wanted, including (especially) on older devices (pre v11).  I did an ARMv6 build and ran this on a Galaxy Mini running Android 2.3.6, but the more the merrier.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: 21f64facd467

[Approval Request Comment]

This is a good candidate for uplift.  It needs to bake for a few days, but we know we want it, and it would be nice to uplift just to m-a rather than all the way to m-b, so opening the approval request early.

Bug caused by (feature/regressing bug #): initial FxA landing.

User impact if declined: Initial sync status UX wasn't anything like what UX requested.  This gets us most of the way to what was requested.

Testing completed (on m-c, etc.): Tested locally on multiple devices.  Needs to bake for a few days.

Risk to taking this patch (and alternatives if risky): low.

String or IDL/UUID changes made by this patch: none.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21f64facd467

Comment 7

[Nick Alexander :nalexander [he/him]]

lsblakk: this has not yet landed on Aurora, so it's not fixed in Fx 29 yet.  (I can't swizzle the tracking flags.)

Comment 8

[Aaron Train [:aaronmt]]

(In reply to Nick Alexander :nalexander from comment #4)
> All sorts of QA wanted, including (especially) on older devices (pre v11). 
> I did an ARMv6 build and ran this on a Galaxy Mini running Android 2.3.6,
> but the more the merrier.

I've asked the team to take a look at this. So far it looks good to me on Android 4.x

Comment 9

[Paul Feher]

Tested on LG Optimus 4X (4.1.2) looks good

Comment 10

[Ioana Chiorean]

Good also on Galaxy Nexus Android 4.1 and HTC Desire HD Android 2.3.

Comment 11

[Catalin Suciu [:csuciu]]

Looks good on Acer Iconia (3.2.1) and Galaxy Note (4.1.2)

Comment 12

[u421692]

Looks good on LG Nexus 4(Android 4.4.2) and Samsung Galaxy R(Android 2.3.4).

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Alcatel One Touch (Android 4.1.2) and Samsung Galaxy Tab 2 (Android 4.2.2)
Looks fine.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a18745c1f289