Closed Bug 977358 Opened 7 years ago Closed 7 years ago

Replace status activity header with "Signed in as"

Categories

(Firefox for Android :: Android Sync, defect)

All
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Tracking Status
firefox29 --- wontfix
firefox30 --- verified
firefox31 --- verified
firefox32 --- verified

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Separate ticket to make uplifting the code easier.
https://hg.mozilla.org/integration/fx-team/rev/c9a2edd50450
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c9a2edd50450
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to Nick Alexander :nalexander from comment #0)
> Separate ticket to make uplifting the code easier.

What exactly does it mean "uplifting"?

Also: I can't find any reference in the code (yet) to this string. How exactly is it used? Concatenated with another string?
(In reply to Francesco Lodolo [:flod] from comment #3)
> (In reply to Nick Alexander :nalexander from comment #0)
> > Separate ticket to make uplifting the code easier.
> 
> What exactly does it mean "uplifting"?

Hi flod!  We know we want to "uplift" a bunch of things from Nightly to Aurora (and some to Beta).  This is part of a series of tickets that change the Sync Status activity; we broke out all of the code and layout changes into a few tickets that are careful not to touch strings (so they can be uplifted), and then this final one is the only string change (which cannot be uplifted).

> Also: I can't find any reference in the code (yet) to this string. How
> exactly is it used? Concatenated with another string?

It is used at https://hg.mozilla.org/mozilla-central/rev/c9a2edd50450#l2.11 -- it replaces a header in the Sync Status screen.
Verified as fixed on:
Builds:
32.0a1 (2014-05-12)
31.0a2 (2014-05-12)
30.0

Devices:
Galaxy Nexus (Android 4.2.1)
Samsung S3 (Android 4.3)

This is still reproducible on release build.
Considering that the Firefox 30 was released I will change flags from FF29 to wontfix;
Based on comment 5 I will mark the bug as verified.
Status: RESOLVED → VERIFIED
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.