977395 - Add promise.catch

Status: RESOLVED WORKSFORME

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Brandon Benvie [:benvie]]

DOM Promises have a "catch" method on Promise.prototype. Despite add-on sdk promises being deprecated, we'd like to have API parity. We're also adding "catch" to Promise.jsm as part of bug 941920.

"catch" is simply implemented as `return this.then(undefined, onReject)`.

Comment 1

[Tomislav Jovanovic :zombie]

fixing this bug should include a test, and probably replacing uses of: 

  promise.then(undefined, onReject);

with:

  promise.catch(onReject);

throughout the SDK code.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Due to bug Bug 881047, sdk/core/promise will use Promise.jsm promises, so this will be redundant once that lands.

Comment 3

[Brandon Benvie [:benvie]]

Don't we still need to do this, just not in the addon-sdk?

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

For Promise.jsm? Doesn't bug 941920 address that?

Comment 5

[Brandon Benvie [:benvie]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #4)
> For Promise.jsm? Doesn't bug 941920 address that?

No, for the remaining devtools code that hasn't been ported to use Promise.jsm. Promises from that code will be missing a .catch method, so we can't reliably use it everywhere unless we're sure of the source of a promise.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Ah, in that case we should probably just do it in the copied promise code in devtools after bug 995184.

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

this is resolved right?

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

This would be referring to the old sync SDK promises which are no longer in the SDK, but still exist in some components of devtools:
https://github.com/mozilla/gecko-dev/blob/master/toolkit/devtools/deprecated-sync-thenables.js

Not sure it's worthwhile to add, although unsure where all these consumers of this are -- either way, this would be a dev tools bug, not an SDK bug.