977406 - featured versions that have aged out still display on the homepage

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Lonnen :lonnen]

Thunderbird 24.1.0 is on the front page of stage right now, but it appears to have aged out and is not accessible in other parts of the webapp. This leads to automation failures, but more importantly it leads to broken links on the front page of the site.

I think this is a dupe of a similar issue, but I can't seem to find it anymore.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Chris Lonnen :lonnen from comment #0)
> Thunderbird 24.1.0 is on the front page of stage right now, but it appears
> to have aged out and is not accessible in other parts of the webapp. This
> leads to automation failures, but more importantly it leads to broken links
> on the front page of the site.
> 
> I think this is a dupe of a similar issue, but I can't seem to find it
> anymore.

Yeah, this is an "annoying" problem for Web QA:

https://bugzilla.mozilla.org/show_bug.cgi?id=971667#c3

The B2G-specific pieces are:

5:19:15 PM <rhelmer> stephend: I am working on bug 928051 which is blocking bug 965481
5:19:22 PM <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=928051 nor, --, ---, rhelmer, ASSI, Make data from B2G partner builds appear in reports_clean and friends
5:19:24 PM <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=965481 nor, --, ---, rhelmer, ASSI, Generate topcrasher reports for B2G

But, really, we shouldn't let users in the UI feature any version for which there's no data (or, if there's data when they do, we should check and purge, when that gets removed).  I don't want our automation crying wolf so often over this (and it happens in prod, which, affects the user experience, to whatever (arguable) degree).

Comment 3

[Robert Helmer [:rhelmer]]

What I think is going on is that Thunderbird doesn't have the usual 4 featured versions (Nightly, Aurora, Beta, Release) and 24.1.0 has expired, but for some reason this version is being selected for the front page (which is probably the bug here):

breakpad=# select sunset_date from product_versions where product_name = 'Thunderbird' and version_string = '24.1.0';
 sunset_date 
-------------
 2014-02-26
(1 row)

Comment 4

[Robert Helmer [:rhelmer]]

Looking into this a little, I think the bug is that the code for this view does not exclude expired versions:

https://crash-stats.mozilla.com/home/frontpage_json?product=Thunderbird

Comment 5

[Robert Helmer [:rhelmer]]

PR: https://github.com/mozilla/socorro/pull/1920

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

I just ran across this issue today while running the Socorro tests. The failed test links to this bug. That was kind of impressive!

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/adf86bd2517e9fa326e9c2a62bb166d56aa24d70
fix bug 977406 - exclude expired versions from front page graph

https://github.com/mozilla/socorro/commit/7d295155e343781adeeb6373ebbd37d2499c0164
Merge pull request #1920 from rhelmer/bug977406-expired-featured-version

fix bug 977406 - exclude expired versions from front page graph

Comment 8

[Matt Brandt [:mbrandt]]

Reopening for further investigation - bug 987581 was recently opened.

* Thunderbird 24.1.1 is listed as featured version but 404s

Comment 9

[Robert Helmer [:rhelmer]]

This was landed and should fix the problem, but was accidentally backed out when there was an accidental force-push to master right after this landed.

I've opened a new PR to rebase and make sure tests still work, the code itself was already reviewed:
https://github.com/mozilla/socorro/pull/1971

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b7211d5895ea6cb0938a3dadb3fadbd9915164ce
fix bug 977406 - exclude expired versions from front page graph

https://github.com/mozilla/socorro/commit/8927bd2d979f1393e2dc8c673507ccafe6efd0e8
Merge pull request #1971 from rhelmer/bug977406-expired-featured-version

fix bug 977406 - exclude expired versions from front page graph

Comment 11

[Matt Brandt [:mbrandt]]

QA verifed on stage - thanks rhelmer!

09:35 qatestbot: Project socorro.stage.saucelabs build #967: FIXED in 2 min 32 sec: http://selenium.qa.mtv2.mozilla.com:8080/job/socorro.stage.saucelabs/967/