977474 - [B2G] [NetworkCommandOptions] Combine the prefixLength, prefix, mask and maskLength into one

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a follow-up of Bug #976959 [1] +++

NetworkOptions has three attributes, prefix/prefixLength/maskLength, standing for the same thing. We should combine them into one and "unsigned long" looks the right type for this attribute.

[1] Please see bug 976959 comment #8.

Comment 1

[Edgar Chen [:edgar]]

We should address bug 976959 comment #12 here as well.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 1: Interfaces changes, v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part 2: NetworkUtils/NetworkSevice changes, v1

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part 3: NetworkManager changes, v1

Comment 5

[Edgar Chen [:edgar]]

Attachment: Part 4: Wifi changes, v1

Comment 6

[Edgar Chen [:edgar]]

Just WIP patches, not verify yet.

Comment 7

[Edgar Chen [:edgar]]

It seems some other parameters can also be merged together:
- enabled, enable
- wifiStartIp, usbStartIp, startIp
- wifiEndIp, usbEndIp, endIp

Comment 8

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #6)
> Just WIP patches, not verify yet.

Just verify them with dolphin:
- Wifi connection
- Mobile connection
- Wifi hotspot + Mobile
- Usb tethering + Mobile
- Usb tethering + Wifi

Comment 9

[Vincent Chang[:vchang][changyihsin]]

Thanks for you patches to refacor this. Looks good.

Comment 10

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 8417969 [details] [diff] [review]
Part 1: Interfaces changes, v1

Review of attachment 8417969 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for being late. Looks good to me :)

Comment 11

[Edgar Chen [:edgar]]

Comment on attachment 8417969 [details] [diff] [review]
Part 1: Interfaces changes, v1

Hi Olli, we just remove some redundant attributes in this bug. Could you help to review this? Thank you.

Comment 12

[Edgar Chen [:edgar]]

Unassigning myself as I am no longer working on this.

Comment 13

[BMO Automation]

Firefox OS is not being worked on