Closed Bug 977474 Opened 7 years ago Closed 3 years ago

[B2G] [NetworkCommandOptions] Combine the prefixLength, prefix, mask and maskLength into one

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-b2g:-)

RESOLVED WONTFIX
blocking-b2g -

People

(Reporter: edgar, Unassigned)

References

Details

Attachments

(4 files)

+++ This bug was initially created as a follow-up of Bug #976959 [1] +++

NetworkOptions has three attributes, prefix/prefixLength/maskLength, standing for the same thing. We should combine them into one and "unsigned long" looks the right type for this attribute.

[1] Please see bug 976959 comment #8.
Depends on: 864931
We should address bug 976959 comment #12 here as well.
Component: General → RIL
blocking-b2g: --- → backlog
Just WIP patches, not verify yet.
Summary: B2G: [NetworkOption] Combine the prefixLength, prefix and maskLength into one → [B2G] [NetworkCommandOptions] Combine the prefixLength, prefix and maskLength into one
It seems some other parameters can also be merged together:
- enabled, enable
- wifiStartIp, usbStartIp, startIp
- wifiEndIp, usbEndIp, endIp
(In reply to Edgar Chen [:edgar][:echen] from comment #6)
> Just WIP patches, not verify yet.

Just verify them with dolphin:
- Wifi connection
- Mobile connection
- Wifi hotspot + Mobile
- Usb tethering + Mobile
- Usb tethering + Wifi
Attachment #8417969 - Flags: review?(vchang)
Attachment #8417969 - Flags: review?(htsai)
Attachment #8417971 - Flags: review?(vchang)
Attachment #8417973 - Flags: review?(vchang)
Attachment #8417975 - Flags: review?(vchang)
Blocks: 1041397
Attachment #8417969 - Flags: review?(vchang) → review+
Attachment #8417971 - Flags: review?(vchang) → review+
Attachment #8417973 - Flags: review?(vchang) → review+
Attachment #8417975 - Flags: review?(vchang) → review+
Thanks for you patches to refacor this. Looks good.
Comment on attachment 8417969 [details] [diff] [review]
Part 1: Interfaces changes, v1

Review of attachment 8417969 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for being late. Looks good to me :)
Attachment #8417969 - Flags: review?(htsai) → review+
Comment on attachment 8417969 [details] [diff] [review]
Part 1: Interfaces changes, v1

Hi Olli, we just remove some redundant attributes in this bug. Could you help to review this? Thank you.
Attachment #8417969 - Flags: review?(bugs)
Attachment #8417969 - Flags: review?(bugs) → review+
blocking-b2g: backlog → -
Blocks: 1118675
Summary: [B2G] [NetworkCommandOptions] Combine the prefixLength, prefix and maskLength into one → [B2G] [NetworkCommandOptions] Combine the prefixLength, prefix, mask and maskLength into one
Unassigning myself as I am no longer working on this.
Assignee: echen → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.