977598 - Contacts search UI sometimes doesn't get painted properly

Status: RESOLVED WORKSFORME

(Core :: Panning and Zooming, defect)

Description

[Noemí Freire (:noemi)]

Follow up for Bug 972091 to solve it at platform level. It seems forcing a repaint should solve the issue. A temporary patch was applied for v1.3 but it should be properly fixed in gecko.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

STR at https://bugzilla.mozilla.org/show_bug.cgi?id=972091#c0, reduced down to https://bugzilla.mozilla.org/show_bug.cgi?id=972091#c4

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

I don't see this as a blocker, it seems to be an implementation detail.  We may want to make the change in the 1.4 timeframe, if there is time, but what's wrong with the current 1.3 solution, other than the code looks ugly?

Comment 3

[Etienne Segonzac (:etienne)]

(In reply to Milan Sreckovic [:milan] from comment #2)
> I don't see this as a blocker, it seems to be an implementation detail.  We
> may want to make the change in the 1.4 timeframe, if there is time, but
> what's wrong with the current 1.3 solution, other than the code looks ugly?

Well forcing reflows randomly everywhere in gaia when we think the content might not repaint properly sounds like a strategy that could turn bad really quickly...

Comment 4

[Etienne Segonzac (:etienne)]

But to be fair, we need to make this bug more actionable :)

Copying the STR from the previous bug:
Description:
If the user manually creates a contact, logs into Facebook, imports a Gmail contact that has a different first and last name but contains the same phone number as the manual contact and then backs out of the "finding duplicate contacts" window, the header bar, search bar and the contacts themselves will be missing on the main contacts' view.  

Prerequisite: Create a contact on Gmail that has a first and last name and the phone number "123456789".

Repro Steps:
1)  Updated Buri to Build ID: 20140212004003
2)  Tap on the "Contacts" app.
3)  Tap on the "+" to create a new contact.
4)  For first name put "Angie", last name "May" and "123456789" for the phone number.
5)  Tap "Done" to save the contact.
6)  Tap on the "Gear" icon, tap on "Facebook Sync friends" and log into Facebook.
7)  When the list of contacts for Facebook is shown to import, tap on the "X" button to close the "Facebook Friends" window. Do not import any contacts. 
8)  Tap on "Import Contacts" and then tap on "Gmail".
9)  Log into Gmail, select a contact that has the same phone number as the manually created contact but has a different first and last name.
10) Tap on "Update". 
11) Tap the "Back Arrow" to return to "Settings" after importing the Gmail contact and then tap on "Done" to return to the main contacts' window.
12) Tap on the manually created contact "Angie May" and then tap on "Find duplicate contacts". 
13) Tap on the "X" button to close the "Merge duplicates" window and then tap on the "Back Arrow" to return to the main contact's view.

Comment 5

[Jose Manuel Cantera]

(In reply to Etienne Segonzac (:etienne) from comment #3)
> (In reply to Milan Sreckovic [:milan] from comment #2)
> > I don't see this as a blocker, it seems to be an implementation detail.  We
> > may want to make the change in the 1.4 timeframe, if there is time, but
> > what's wrong with the current 1.3 solution, other than the code looks ugly?
> 
> Well forcing reflows randomly everywhere in gaia when we think the content
> might not repaint properly sounds like a strategy that could turn bad really
> quickly...

oh absolutely. this kind of bugs should be fixed in Gecko.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

OK, different picture painted in comment 4.  Form the original description, it sounded like we have the problem fixed, in Gaia, and we want to replace that (ugly) fix with a fix in Gecko.  From comment 4, it sounds like we actually have a reproducible bug today, without a fix anywhere, and we want to fix it.
Correct?

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

We will do the proper solution in 1.5, and live with the workaround in 1.4.  If the bug comes back despite the workaround, let's open an explicit bug for it.

Comment 8

[Jason Smith [:jsmith]]

If were this close to 2.0 FL, then this probably isn't going to happen for 2.0 either.

Comment 9

[bhavana bajaj [:bajaj]]

(In reply to Jason Smith [:jsmith] from comment #8)
> If were this close to 2.0 FL, then this probably isn't going to happen for
> 2.0 either.

Let's get the workaround landed on 2.0 as well, we can uplift the clean-up if fixed within a few days of FL depending on the risk. Milan, leaving it to you to have it on your team's radar by setting a target feature-b2g flag.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I tried reproducing this bug on the latest master code on the flame, but was unable to. It has likely been fixed already. I note that the workaround patch that landed in bug 972091 was only for 1.3 and isn't in 1.4 or higher branches, so presumably this bug is no longer a concern. I'll try on a hamachi as well but right now I'm having issues getting a working build on there at all. If anybody else can repro the issue still please feel free to reopen.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Unable to reproduce on a Hamachi running latest master code.