977862 - Customization mode outline doesn't appear on drag for empty toolbars

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Tim Nguyen :ntim]

Not sure if this is expected, but I noticed this with the new customization mode outlines.

Comment 1

[Tim Nguyen :ntim]

I think this is expected as other browsers act the same way.

Comment 2

[Matthew N. [:MattN]]

Right, I noticed this while implementing bug 963576 so instead used a custom attribute. Morphing this to cover 963576 comment 35:
(In reply to Tim Nguyen [:ntim] from comment #36)
> (In reply to Tim Nguyen [:ntim] from comment #35)
> > Unfortunatly, I can't see the outline on dragover (with an item grabbed).
> > But, I can see the outline on hover.
> 
> OS : Windows
Please specify the version. Is it 8.1 like in the OS field?

Possibly related to bug 977516

Comment 3

[Tim Nguyen :ntim]

I use Win 8.1. 
Well, actually, I don't think it's related to the glass fog, since I get the problem on other toolbars too (bookmarks toolbar, addon toolbars). Btw, those outlines appear on hover fine. So it's probably due to the fact that the dragover event isn't triggered properly.

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I'm seeing a similar issue on Windows 8.1 and Windows XP.

When moving the mouse over an empty part of the tab strip, I don't see an outline.
When moving the mouse over an icon in the tab strip (or the tabs themselves), the outline is there.
When dragging an icon to the tab strip, the outline is visible, regardless of the distinction above.

Tim, is this the same issue you are seeing or something else?

Comment 5

[Tim Nguyen :ntim]

(In reply to Philipp Sackl [:phlsa] from comment #4)
> I'm seeing a similar issue on Windows 8.1 and Windows XP.
> 
> When moving the mouse over an empty part of the tab strip, I don't see an
> outline.
> When moving the mouse over an icon in the tab strip (or the tabs
> themselves), the outline is there.
> When dragging an icon to the tab strip, the outline is visible, regardless
> of the distinction above.
> 
> Tim, is this the same issue you are seeing or something else?

I do also have your issue, but the initial issue I reported is something else.
When you drag an item over any toolbar (bookmarks bar for example) or over the menu panel, the outline doesn't show up.

What's weird is that it shows up when you drag over the tabbar.

Comment 6

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Tim Nguyen [:ntim] from comment #5)
> (In reply to Philipp Sackl [:phlsa] from comment #4)
> > I'm seeing a similar issue on Windows 8.1 and Windows XP.
> > 
> > When moving the mouse over an empty part of the tab strip, I don't see an
> > outline.
> > When moving the mouse over an icon in the tab strip (or the tabs
> > themselves), the outline is there.
> > When dragging an icon to the tab strip, the outline is visible, regardless
> > of the distinction above.
> > 
> > Tim, is this the same issue you are seeing or something else?
> 
> I do also have your issue, but the initial issue I reported is something
> else.
Then I'll file a separate bug for this issue.

> When you drag an item over any toolbar (bookmarks bar for example) or over
> the menu panel, the outline doesn't show up.

That's weird, I can't reproduce this on my Windows 8 VM.

Comment 7

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #5)
> (In reply to Philipp Sackl [:phlsa] from comment #4)
> > I'm seeing a similar issue on Windows 8.1 and Windows XP.
> > 
> > When moving the mouse over an empty part of the tab strip, I don't see an
> > outline.
> > When moving the mouse over an icon in the tab strip (or the tabs
> > themselves), the outline is there.
> > When dragging an icon to the tab strip, the outline is visible, regardless
> > of the distinction above.
> > 
> > Tim, is this the same issue you are seeing or something else?
> 
> I do also have your issue, but the initial issue I reported is something
> else.
> When you drag an item over any toolbar (bookmarks bar for example) or over
> the menu panel, the outline doesn't show up.
> 
> What's weird is that it shows up when you drag over the tabbar.

Can you reproduce this on a clean profile? Because I can't reproduce on win7 either... :-\

Comment 8

[Tim Nguyen :ntim]

Actually, on a clean profile, I can't reproduce this issue, neither Philipp's issue.

Comment 9

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #8)
> Actually, on a clean profile, I can't reproduce this issue, neither
> Philipp's issue.

It'd be interesting if we can figure out what's breaking this, then, if it's an add-on or some configuration of buttons / widgets on toolbars...

Comment 10

[Tim Nguyen :ntim]

But, the menu panel has no outline even on a clean profile.

(In reply to :Gijs Kruitbosch from comment #9)
> (In reply to Tim Nguyen [:ntim] from comment #8)
> > Actually, on a clean profile, I can't reproduce this issue, neither
> > Philipp's issue.
> 
> It'd be interesting if we can figure out what's breaking this, then, if it's
> an add-on or some configuration of buttons / widgets on toolbars...
I'll try to investigate the issue.

Comment 11

[Tim Nguyen :ntim]

Ok, found the issue, only empty toolbars are affected.

Comment 12

[:Gijs (he/him)]

The menu panel isn't meant to have an outline - there's the single item outlines at the bottom of that area which should indicate that you can drag items there.

Comment 13

[:Gijs (he/him)]

Attachment: dragging items onto an empty toolbar shows no drag outline,

This does the trick for me

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8388211 [details] [diff] [review]
dragging items onto an empty toolbar shows no drag outline,

Review of attachment 8388211 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, and I tested that it fixes the problem on Windows 7.

Thanks Gijs!

Comment 15

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/1e331682951f

Comment 16

[:Gijs (he/him)]

Comment on attachment 8388211 [details] [diff] [review]
dragging items onto an empty toolbar shows no drag outline,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: empty bookmarks toolbar / additional toolbars won't have a drag outline
Testing completed (on m-c, etc.): soon on m-c
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e331682951f

Comment 18

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7e756204cadf