977950 - Dragging text no longer works after Bug 923054

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gary [:streetwolf52]]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140227163648

Steps to reproduce:

1. Install Super Drag 0.10 at https://addons.mozilla.org/en-US/firefox/addon/super-drag/?src=ss

2. Select some text and drag it.  Look below for what SD does.  


Actual results:

Dragging selected text does nothing.


Expected results:

Super Drag extends the feature of drag & drop. For example, you can drag a link to open it in a new background, foreground and current tab. You can also drag text to search, by using the default search engine, or select what you want. And for image, you can drag it to view in a background tab, foreground tab, or save it to the default download location.

Super Drag supports links, text and images.

    links - open it in background tab, foreground tab or current tab.
    text - search it in background tab, foreground tab or current tab.
    images - open it in background tab, foreground tab or save it.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Thank you.  Looking.

Comment 2

[Boris Zbarsky [:bzbarsky]]

ACtually, drag of text is just generally broken.  This is because the old logic in nsEventStateManager::DoDefaultDragStart allowed dragTarget to be a textnode (which could only happen when aDragTarget was a textnode) but the new logic requires it to be an element.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix dragging of text to work again.

There are three changes here:

1) Fix a refcounting bug that snuck in in bug 923054.
2) Remove what I think is an incorrect null-check from bug 923054.
   Unless we really do want to force a non-null datatransfer there?  The
   XPCOM code doesn't seem to.
3) Fix this bug by allowing a non-element dragTarget.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8383460 [details] [diff] [review]
Fix dragging of text to work again.


> NS_IMETHODIMP
> DataTransfer::GetFiles(nsIDOMFileList** aFileList)
> {
>   ErrorResult rv;
>-  *aFileList = GetFiles(rv);
>+  NS_IF_ADDREF(*aFileList = GetFiles(rv));
>   return rv.ErrorCode();
> }
> 
yikes

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b87877dfeb49

Comment 7

[Gary [:streetwolf52]]

Patch appears to be working fine.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b87877dfeb49