978030 - Fix browser_pluginnotification.js test (use "anonid" to access plugin placeholder element, Port Bug 967694)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank Wein [:mcsmurf]]

Currently browser_pluginnotification.js still uses the old way to access plugin content in a test:
doc.getAnonymousElementByAttribute(plugin, "class", "mainBox");

This no longer seems to work, you now need to use
doc.getAnonymousElementByAttribute(plugin, "anonid", "main");

See Bug 853973 for the Firefox fix for this and Bug 914611 for the actual code fix in SeaMonkey plugin placeholder code.

Also Bug 967694 needs to be ported to fix test 22 in that file as currently without the fix the test fails with
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | uncaught exception - TypeError: pluginNode.getObjectValue is not a function at chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js:1035

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

This fixes the plugin tests, I tested it locally, I think this one is trivial enough that no further review is needed. So far these two tests (still) fail, I'll investigate that:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Test 3, Should not be a missing plugin list
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/browser/test/browser_pluginnotification.js | Test 13b, Plugin should not have visible overlay

Comment 2

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/51dbd2928576

Comment 3

[Frank Wein [:mcsmurf]]

Doh, forgot about my patch in Attachment 8351462 [details] [diff] :o I've already written that patch over there.