Closed Bug 978071 Opened 6 years ago Closed 4 years ago

B2G Emulator: support IPv6

Categories

(Firefox OS Graveyard :: Emulator, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
FxOS-S7 (18Sep)
Tracking Status
firefox43 --- fixed

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

Attachments

(5 files, 4 obsolete files)

+++ This bug was initially created as a clone of Bug #957917 +++
Attached file Github PR for external/qemu (obsolete) —
Attached file Github pull request for hardware/ril (obsolete) —
Blocks: 979137
Add RIL quirk ro.moz.ril.ipv6.
https://tbpl.mozilla.org/?tree=Try&rev=bcdd99c09d9d

[[B2G ICS Emulator Opt]]: M7, Mnw

B2GRunner TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudio.html | application timed out after 330.0 seconds with no output
PROCESS-CRASH | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudio.html | application crashed [@ user_sctp_timer_iterate]
Return code: 247

abort: HTTP Error 500: Internal Server Error
Automation Error: hg not responding
Return code: 255
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_outgoing_emergency_in_airplane_mode.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_emergency_label.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_conference.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_call_mute.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_outgoing_answer_radio_off.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_data_connection.js |
Return code: 10

[[B2G ICS Emulator Debug]]: M9

922 INFO TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicDataOnly.html | Test timed out.
[Child 705] ###!!! ABORT: ActorDestroy by IPC channel failure at LayerTransactionChild: file ../../../gecko/gfx/layers/ipc/LayerTransactionChild.cpp, line 95
04-10 14:07:13.345   705   705 I GeckoDump: 922 INFO TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicDataOnly.html | Test timed out.
04-10 14:07:52.755   705   705 I Gecko   : [Child 705] ###!!! ABORT: ActorDestroy by IPC channel failure at LayerTransactionChild: file ../../../gecko/gfx/layers/ipc/LayerTransactionChild.cpp, line 95
04-10 14:07:52.835   705   705 E Gecko   : mozalloc_abort: [Child 705] ###!!! ABORT: ActorDestroy by IPC channel failure at LayerTransactionChild: file ../../../gecko/gfx/layers/ipc/LayerTransactionChild.cpp, line 95
04-10 14:07:52.855   705   705 F libc    : Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1)
This usually indicates the B2G process has crashed
Fixed net->dns indexing in amodem_init_rmnets().
Attachment #8385121 - Attachment is obsolete: true
- Fill in 'type', 'status' and 'active' fields in requestSetupDataCall()
- Deactivate pdp when request data call fails after activation
Attachment #8385122 - Attachment is obsolete: true
Attached patch Enable mobile data ipv6 tests. (obsolete) — Splinter Review
Enable test_mobile_data_ipv6.js but comment out IPv4v6 for now.
Comment on attachment 8633916 [details] [review]
Github PR for external/qemu (ics)

Edgar, would you mind reviewing this? Thanks.
Attachment #8633916 - Flags: review?(echen)
Comment on attachment 8633927 [details] [review]
Github PR for hardware/ril (ics)

Edgar, would you mind reviewing this? Thanks.
Attachment #8633927 - Flags: review?(echen)
Comment on attachment 8633928 [details] [diff] [review]
Enable mobile data ipv6 tests.

Review of attachment 8633928 [details] [diff] [review]:
-----------------------------------------------------------------

Edgar, would you mind reviewing this? Thanks.
Attachment #8633928 - Flags: review?(echen)
Comment on attachment 8633928 [details] [diff] [review]
Enable mobile data ipv6 tests.

Review of attachment 8633928 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thank you.
Attachment #8633928 - Flags: review?(echen) → review+
Comment on attachment 8633927 [details] [review]
Github PR for hardware/ril (ics)

Looks good, thank you.
Attachment #8633927 - Flags: review?(echen) → review+
Comment on attachment 8633916 [details] [review]
Github PR for external/qemu (ics)

r=me with comments on github addressed.
Attachment #8633916 - Flags: review?(echen) → review+
I created a new PR, since the original PR contains other commits.
Attachment #8389016 - Attachment is obsolete: true
Attachment #8656989 - Flags: review?(echen)
Comment on attachment 8656989 [details] [review]
Github PR for device/generic/goldfish (ics)

Thank you.
Attachment #8656989 - Flags: review?(echen) → review+
Rebased after bug 1167132.
Attachment #8633928 - Attachment is obsolete: true
Attachment #8657691 - Flags: review+
checkin-needed for emulator part: attachment 8633916 [details] [review], 8633927 and 8656989.
Keywords: checkin-needed
(In reply to Jessica Jong [:jjong] [:jessica] from comment #19)
> checkin-needed for emulator part: attachment 8633916 [details] [review], 8633927 and
> 8656989.

does attachment with  Enable mobile data ipv6 tests. r=echen  also need checkin ?
Flags: needinfo?(jjong)
(In reply to Carsten Book [:Tomcat] from comment #21)
> (In reply to Jessica Jong [:jjong] [:jessica] from comment #19)
> > checkin-needed for emulator part: attachment 8633916 [details] [review], 8633927 and
> > 8656989.
> 
> does attachment with  Enable mobile data ipv6 tests. r=echen  also need
> checkin ?

Yes, that needs to be merged after the emulator parts, otherwise the test case will fail. Thanks.
Flags: needinfo?(jjong)
Reopening as test case part in gecko is not merged yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/4d3afc0190a5
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Blocks: 1183002
Depends on: 1203828
No longer depends on: 1203828
Hi Jessica, now I am working on porting this fix to emualtor-x86-kk. For qemu/ril patch, I will cherry-pick them directly. But the properties configuration for kk lives in different repository [1]. Could you help to create a pull request to platform_build:b2g-4.4.2_r1 for kk? Thank you.

[1] https://github.com/mozilla-b2g/platform_build/blob/b2g-4.4.2_r1/target/product/emulator.mk#L69-L73
Flags: needinfo?(jjong)
(In reply to Edgar Chen [:edgar][:echen] from comment #26)
> Hi Jessica, now I am working on porting this fix to emualtor-x86-kk. For
> qemu/ril patch, I will cherry-pick them directly. But the properties
> configuration for kk lives in different repository [1]. Could you help to
> create a pull request to platform_build:b2g-4.4.2_r1 for kk? Thank you.
> 
> [1]
> https://github.com/mozilla-b2g/platform_build/blob/b2g-4.4.2_r1/target/
> product/emulator.mk#L69-L73

Sure! Keeping NI for tracking.
Verified on emulator-kk by using 'getprop ro.moz.ril.ipv6'.

Edgar, would you mind reviewing this? Thanks.
Flags: needinfo?(jjong)
Attachment #8659792 - Flags: review?(echen)
Comment on attachment 8659792 [details] [review]
Github PR for build (kk)

I will help to merge this pull request. Thank you, Jessica.
Attachment #8659792 - Flags: review?(echen) → review+
Depends on: 1204425
You need to log in before you can comment on or make changes to this bug.