978071 - B2G Emulator: support IPv6

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #957917 +++

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github PR for external/qemu

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github pull request for hardware/ril

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github pull request for device_generic_goldfish

Add RIL quirk ro.moz.ril.ipv6.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

https://tbpl.mozilla.org/?tree=Try&rev=bcdd99c09d9d

[[B2G ICS Emulator Opt]]: M7, Mnw

B2GRunner TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudio.html | application timed out after 330.0 seconds with no output
PROCESS-CRASH | /tests/dom/media/tests/mochitest/test_dataChannel_basicAudio.html | application crashed [@ user_sctp_timer_iterate]
Return code: 247

abort: HTTP Error 500: Internal Server Error
Automation Error: hg not responding
Return code: 255
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_outgoing_emergency_in_airplane_mode.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_emergency_label.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_conference.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_call_mute.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_outgoing_answer_radio_off.js |
    raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_data_connection.js |
Return code: 10

[[B2G ICS Emulator Debug]]: M9

922 INFO TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicDataOnly.html | Test timed out.
[Child 705] ###!!! ABORT: ActorDestroy by IPC channel failure at LayerTransactionChild: file ../../../gecko/gfx/layers/ipc/LayerTransactionChild.cpp, line 95
04-10 14:07:13.345   705   705 I GeckoDump: 922 INFO TEST-UNEXPECTED-FAIL | /tests/dom/media/tests/mochitest/test_dataChannel_basicDataOnly.html | Test timed out.
04-10 14:07:52.755   705   705 I Gecko   : [Child 705] ###!!! ABORT: ActorDestroy by IPC channel failure at LayerTransactionChild: file ../../../gecko/gfx/layers/ipc/LayerTransactionChild.cpp, line 95
04-10 14:07:52.835   705   705 E Gecko   : mozalloc_abort: [Child 705] ###!!! ABORT: ActorDestroy by IPC channel failure at LayerTransactionChild: file ../../../gecko/gfx/layers/ipc/LayerTransactionChild.cpp, line 95
04-10 14:07:52.855   705   705 F libc    : Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1)
This usually indicates the B2G process has crashed

Comment 5

[Jessica Jong [:jessica] (inactive)]

Attachment: Github PR for external/qemu (ics)

Fixed net->dns indexing in amodem_init_rmnets().

Comment 6

[Jessica Jong [:jessica] (inactive)]

Attachment: Github PR for hardware/ril (ics)

- Fill in 'type', 'status' and 'active' fields in requestSetupDataCall()
- Deactivate pdp when request data call fails after activation

Comment 7

[Jessica Jong [:jessica] (inactive)]

Attachment: Enable mobile data ipv6 tests.

Enable test_mobile_data_ipv6.js but comment out IPv4v6 for now.

Comment 8

[Jessica Jong [:jessica] (inactive)]

I have revised Vicamo's patches and they look good now!

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=89a3c0ca6f66&exclusion_profile=false

Comment 9

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8633916 [details] [review]
Github PR for external/qemu (ics)

Edgar, would you mind reviewing this? Thanks.

Comment 10

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8633927 [details] [review]
Github PR for hardware/ril (ics)

Edgar, would you mind reviewing this? Thanks.

Comment 11

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8633928 [details] [diff] [review]
Enable mobile data ipv6 tests.

Review of attachment 8633928 [details] [diff] [review]:
-----------------------------------------------------------------

Edgar, would you mind reviewing this? Thanks.

Comment 12

[Edgar Chen [:edgar]]

Comment on attachment 8633928 [details] [diff] [review]
Enable mobile data ipv6 tests.

Review of attachment 8633928 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thank you.

Comment 13

[Edgar Chen [:edgar]]

Comment on attachment 8633927 [details] [review]
Github PR for hardware/ril (ics)

Looks good, thank you.

Comment 14

[Edgar Chen [:edgar]]

Comment on attachment 8633916 [details] [review]
Github PR for external/qemu (ics)

r=me with comments on github addressed.

Comment 15

[Jessica Jong [:jessica] (inactive)]

Attachment: Github PR for device/generic/goldfish (ics)

I created a new PR, since the original PR contains other commits.

Comment 16

[Edgar Chen [:edgar]]

Comment on attachment 8656989 [details] [review]
Github PR for device/generic/goldfish (ics)

Thank you.

Comment 17

[Jessica Jong [:jessica] (inactive)]

Attachment: Enable mobile data ipv6 tests. r=echen

Rebased after bug 1167132.

Comment 18

[Jessica Jong [:jessica] (inactive)]

I have addressed the review comments on github.

try looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=065a2df37585&exclusion_profile=false&group_state=expanded

Comment 19

[Jessica Jong [:jessica] (inactive)]

checkin-needed for emulator part: attachment 8633916 [details] [review], 8633927 and 8656989.

Comment 20

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/platform_external_qemu/commit/067c08fb3e5744b42b68d1f861245f7d507109bc
https://github.com/mozilla-b2g/platform_hardware_ril/commit/27eb2f04e149fc2c9976d881b1b5984bbe7ee089
https://github.com/mozilla-b2g/device_generic_goldfish/commit/fc5f390fa314385e2a84629ea88284a60b40f7c4

Comment 21

[Carsten Book [:Tomcat]]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #19)
> checkin-needed for emulator part: attachment 8633916 [details] [review], 8633927 and
> 8656989.

does attachment with  Enable mobile data ipv6 tests. r=echen  also need checkin ?

Comment 22

[Jessica Jong [:jessica] (inactive)]

(In reply to Carsten Book [:Tomcat] from comment #21)
> (In reply to Jessica Jong [:jjong] [:jessica] from comment #19)
> > checkin-needed for emulator part: attachment 8633916 [details] [review], 8633927 and
> > 8656989.
> 
> does attachment with  Enable mobile data ipv6 tests. r=echen  also need
> checkin ?

Yes, that needs to be merged after the emulator parts, otherwise the test case will fail. Thanks.

Comment 23

[Jessica Jong [:jessica] (inactive)]

Reopening as test case part in gecko is not merged yet.

Comment 24

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/4d3afc0190a5

Comment 25

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d3afc0190a5

Comment 26

[Edgar Chen [:edgar]]

Hi Jessica, now I am working on porting this fix to emualtor-x86-kk. For qemu/ril patch, I will cherry-pick them directly. But the properties configuration for kk lives in different repository [1]. Could you help to create a pull request to platform_build:b2g-4.4.2_r1 for kk? Thank you.

[1] https://github.com/mozilla-b2g/platform_build/blob/b2g-4.4.2_r1/target/product/emulator.mk#L69-L73

Comment 27

[Jessica Jong [:jessica] (inactive)]

(In reply to Edgar Chen [:edgar][:echen] from comment #26)
> Hi Jessica, now I am working on porting this fix to emualtor-x86-kk. For
> qemu/ril patch, I will cherry-pick them directly. But the properties
> configuration for kk lives in different repository [1]. Could you help to
> create a pull request to platform_build:b2g-4.4.2_r1 for kk? Thank you.
> 
> [1]
> https://github.com/mozilla-b2g/platform_build/blob/b2g-4.4.2_r1/target/
> product/emulator.mk#L69-L73

Sure! Keeping NI for tracking.

Comment 28

[Jessica Jong [:jessica] (inactive)]

Attachment: Github PR for build (kk)

Verified on emulator-kk by using 'getprop ro.moz.ril.ipv6'.

Edgar, would you mind reviewing this? Thanks.

Comment 29

[Edgar Chen [:edgar]]

b2g-kitkat:
https://github.com/mozilla-b2g/platform_external_qemu/commit/b2d449276b015d8fe6cd9ea60c389c7e6975f841
https://github.com/mozilla-b2g/platform_hardware_ril/commit/7132bc11fbc68acfebcd509095562ca04fad5584

Comment 30

[Edgar Chen [:edgar]]

Comment on attachment 8659792 [details] [review]
Github PR for build (kk)

I will help to merge this pull request. Thank you, Jessica.

Comment 31

[Edgar Chen [:edgar]]

b2g-4.4.2_r1:
https://github.com/mozilla-b2g/platform_build/commit/8d83715f08b7849f16a0dfc88f78d5c3a89c0a54