978127 - Update various win8 specific australis customized ui tests to use new Services.metro.supported prop

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/search?find=%2F&string=isInWin8

Comment 1

[:Gijs (he/him)]

And while we're here... I'm guessing this is related to bug 977954? Is Services.metro.supported true only on non-enable-metro builds?

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

easier than I expected. will push to try first.

Comment 3

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/?tree=Try&showall=0&rev=1d404e015db3


(In reply to :Gijs Kruitbosch from comment #1)
> And while we're here... I'm guessing this is related to bug 977954? Is
> Services.metro.supported true only on non-enable-metro builds?

Yeah I can fix that too.

Comment 4

[Jim Mathies [:jimm]]

Attachment: patch

Comment 6

[Jim Mathies [:jimm]]

That added ifdef isn't needed.

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8383761 [details] [diff] [review]
patch

I'll land as soon as that try build comes back green.

Comment 8

[:Gijs (he/him)]

Comment on attachment 8383761 [details] [diff] [review]
patch

Review of attachment 8383761 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet, thanks!

Comment 9

[Jim Mathies [:jimm]]

hmm, I got a failed test on linux browser-chrome - 

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_890140_orphaned_placeholders.js | Should only be in default state if on Win8 - Got false, expected undefined

Comment 10

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/?tree=Try&showall=0&rev=ed2ad9708129

return Services.metro on linux resolved to 'undefined' in an is() test, but we compared it to false. Hopefully this comes up green.

Comment 11

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/a66831238267

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a66831238267

Comment 13

[Brian R. Bondy [:bbondy]]

Comment on attachment 8383761 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Disabling metro
User impact if declined: mochitest browser chrome perm orange failure will persist on mozilla-beta (See bug 990261)
Testing completed (on m-c, etc.): This is on m-c and aurora already which do not have a perm orange failure righ tnow.
Risk to taking this patch (and alternatives if risky): As close to none as possible the change is in a test. 
String or IDL/UUID changes made by this patch: none

Comment 15

[Robert Strong (they/them - no direct email)]

Approval isn't needed for this. You can land this with a=tests

Comment 16

[Ryan VanderMeulen [:RyanVM]]

I'll get this in the morning if Brian doesn't beat me to it.

Comment 17

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a62028aadc99