Closed Bug 978338 Opened 6 years ago Closed 6 years ago

Update new tab site rendering for fixed ratio tile images

Categories

(Firefox :: New Tab Page, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 31

People

(Reporter: Mardak, Assigned: mzhilyaev)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [tiles] p=0 s=it-31c-30a-29b.1 [qa!])

Attachments

(1 file, 1 obsolete file)

The current discussion in bug 975208 point towards having a tile ratio of 243x150 for the image portion. Existing thumbnails should naturally resize to fit that ratio while Directory Tiles will have a background color filling up the empty space around the centered 180x150 image.
Whiteboard: [tiles] → [tiles] p=0
Summary: Update new tab grid rendering for fixed ratio tile images → Update new tab site rendering for fixed ratio tile images
This bug focuses on the per-site display to match the design in bug 975208. The main changes are tile image aspect ratio, border, font family, text spacing, tile spacing.
Blocks: 980014
Assignee: nobody → mzhilyaev
Blocks: 975210
Attached patch V1 (obsolete) — Splinter Review
Site rendering for fixed ratio tile images
Attachment #8390945 - Flags: review?(adw)
No longer blocks: 975210
Comment on attachment 8390945 [details] [diff] [review]
V1

Review of attachment 8390945 [details] [diff] [review]:
-----------------------------------------------------------------

I understand that tile ratio is supposed to be fixed, but this patch fixes the size.  Is that right?  Bug 975208 talks about resizing tiles but it's hard to tell what the final decision was.
Attachment #8390945 - Flags: review?(adw) → review+
(In reply to Drew Willcoxon :adw from comment #3)
> I understand that tile ratio is supposed to be fixed, but this patch fixes
> the size.
The attachment 8385835 [details] specifically says "Each tile will be 243x150 pixels" and there was some discussion to potentially allow future scaling up in size at the fixed ratio (as opposed to scaling down).
Attached patch for checkinSplinter Review
Attachment #8390945 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/c969d36b242d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Hi Anthony, can you review if this bug should be [qa+] or [qa-] for verification.
Flags: needinfo?(anthony.s.hughes)
Whiteboard: [tiles] p=0 → [tiles] p=0 s=it-31c-30a-29b.1
This bug regressed non-default values for newtabpage.rows/.columns: http://imgur.com/a/EFtEl
(In reply to Elbart from comment #9)
> This bug regressed non-default values for newtabpage.rows/.columns:
> http://imgur.com/a/EFtEl
That should be fixed with the followup bug 980014 that will shrink the rows/columns if there's not enough space to display the fixed size tiles.
qa+ for verification.

Do we have automated tests to cover rendering during resize actions?
Flags: needinfo?(anthony.s.hughes)
QA Contact: cornel.ionce
Whiteboard: [tiles] p=0 s=it-31c-30a-29b.1 → [tiles] p=0 s=it-31c-30a-29b.1 [qa+]
Hi Cornel. When can verification of this item be completed? Our iteration ends on Monday, March 31st.
Flags: needinfo?(cornel.ionce)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0

The testing is completed on latest Nightly (Build ID: 20140327030203).
Marking issue verified.
Status: RESOLVED → VERIFIED
Flags: needinfo?(cornel.ionce)
Whiteboard: [tiles] p=0 s=it-31c-30a-29b.1 [qa+] → [tiles] p=0 s=it-31c-30a-29b.1 [qa!]
Blocks: 990416
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
This change makes the new tab page look tiny on higher resolutions, see bug 1016366.
Depends on: 1016366
Component: Tabbed Browser → New Tab Page
Depends on: 1024830
You need to log in before you can comment on or make changes to this bug.