978338 - Update new tab site rendering for fixed ratio tile images

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

The current discussion in bug 975208 point towards having a tile ratio of 243x150 for the image portion. Existing thumbnails should naturally resize to fit that ratio while Directory Tiles will have a background color filling up the empty space around the centered 180x150 image.

Comment 1

[Ed Lee :Mardak]

This bug focuses on the per-site display to match the design in bug 975208. The main changes are tile image aspect ratio, border, font family, text spacing, tile spacing.

Comment 2

[maxim zhilyaev]

Attachment: V1

Site rendering for fixed ratio tile images

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8390945 [details] [diff] [review]
V1

Review of attachment 8390945 [details] [diff] [review]:
-----------------------------------------------------------------

I understand that tile ratio is supposed to be fixed, but this patch fixes the size.  Is that right?  Bug 975208 talks about resizing tiles but it's hard to tell what the final decision was.

Comment 4

[Ed Lee :Mardak]

(In reply to Drew Willcoxon :adw from comment #3)
> I understand that tile ratio is supposed to be fixed, but this patch fixes
> the size.
The attachment 8385835 [details] specifically says "Each tile will be 243x150 pixels" and there was some discussion to potentially allow future scaling up in size at the fixed ratio (as opposed to scaling down).

Comment 5

[Ed Lee :Mardak]

Attachment: for checkin

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c969d36b242d

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c969d36b242d

Comment 8

[Marco Mucci [:MarcoM]]

Hi Anthony, can you review if this bug should be [qa+] or [qa-] for verification.

Comment 9

[Elbart]

This bug regressed non-default values for newtabpage.rows/.columns: http://imgur.com/a/EFtEl

Comment 10

[Ed Lee :Mardak]

(In reply to Elbart from comment #9)
> This bug regressed non-default values for newtabpage.rows/.columns:
> http://imgur.com/a/EFtEl
That should be fixed with the followup bug 980014 that will shrink the rows/columns if there's not enough space to display the fixed size tiles.

Comment 11

[u279076]

qa+ for verification.

Do we have automated tests to cover rendering during resize actions?

Comment 12

[Jenn Chaulk (:jchaulk)]

Hi Cornel. When can verification of this item be completed? Our iteration ends on Monday, March 31st.

Comment 13

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (Windows NT 5.2; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0

The testing is completed on latest Nightly (Build ID: 20140327030203).
Marking issue verified.

Comment 14

[José Jeria]

This change makes the new tab page look tiny on higher resolutions, see bug 1016366.