978475 - Sidebar button image wasn't added correctly - Windows 8 has wrong icons in toolbar, Windows XP misses icon

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

For some reason, the Windows XP icons started appearing on Windows 8 (and maybe all Windows).
I'm fairly sure this is a recent regression, as it happened after an update today.

My Nightly build : 30.0a1 (2014-03-01)

Comment 1

[:Gijs (he/him)]

Mike, any idea what's up here?

Comment 2

[Mike de Boer [:mikedeboer]]

Erm, no. Tim, this means that you saw the Windows 8 icons in a previous build, right?

Comment 3

[Tim Nguyen :ntim]

(In reply to Mike de Boer [:mikedeboer] from comment #2)
> Erm, no. Tim, this means that you saw the Windows 8 icons in a previous
> build, right?

Yeah, saw the win 8 icons in the previous build.

Comment 4

[Tim Nguyen :ntim]

I think it's because of the new australis sidebar widget that arrived on the same day as this bug (bug 960198)

I saw a new icon in the toolbar sprite.

Comment 5

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #4)
> I think it's because of the new australis sidebar widget that arrived on the
> same day as this bug (bug 960198)
> 
> I saw a new icon in the toolbar sprite.

Yup.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Fixed by backing out bug 960198.

Comment 8

[Alice0775 White]

This problem re-appears on
https://hg.mozilla.org/mozilla-central/rev/44ae8462d6ab
Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140312030201

Comment 9

[Shane Caraveo (:mixedpuppy)]

(In reply to Alice0775 White from comment #8)
> This problem re-appears on
> https://hg.mozilla.org/mozilla-central/rev/44ae8462d6ab
> Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0
> ID:20140312030201

@shorlander verified the icons were correct on win8 nightly for him, can you provide any screenshots or more details?

Comment 10

[Alice0775 White]

(In reply to Shane Caraveo (:mixedpuppy) from comment #9)
> (In reply to Alice0775 White from comment #8)
> > This problem re-appears on
> > https://hg.mozilla.org/mozilla-central/rev/44ae8462d6ab
> > Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0
> > ID:20140312030201
> 
> @shorlander verified the icons were correct on win8 nightly for him, can you
> provide any screenshots or more details?

See my Bug 978483.

Comment 11

[Shane Caraveo (:mixedpuppy)]

(In reply to Alice0775 White from comment #10)
> (In reply to Shane Caraveo (:mixedpuppy) from comment #9)
> > (In reply to Alice0775 White from comment #8)
> > > This problem re-appears on
> > > https://hg.mozilla.org/mozilla-central/rev/44ae8462d6ab
> > > Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0
> > > ID:20140312030201
> > 
> > @shorlander verified the icons were correct on win8 nightly for him, can you
> > provide any screenshots or more details?
> 
> See my Bug 978483.

Sorry, still not enough info.  this bug is for both win8 and winxp.  the screenshot in Bug 978483 is winxp, and is old.

Does the problem happen as the subject of this bug claims, and as the initial description, is it just win8 or just winxp?  Do the scrollbars still appear as the screenshot shows?

I'm asking for clarity here because the image shorlander showed me was fine on win8.

Comment 12

[Alice0775 White]

Because, Somebody marked Bug 978483 as the reproduction of this.
Bug 978483 is not fixed for me, then, this bug is not fixed for me.

The Bug 978483 is for Image. The scrollbar is different bug.

Comment 13

[Alice0775 White]

Somebody == Gijs,

So, please ask him why Bug 978483 is duplicate of this.

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Those bugs should be unduped. They were merged because a single solution fixed both issues, but that is no longer the case.

Comment 15

[Alice0775 White]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #14)
> Those bugs should be unduped. They were merged because a single solution
> fixed both issues, but that is no longer the case.

OK.

Comment 16

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.3; rv:30.0) Gecko/20100101 Firefox/30.0
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0

Verified fixed on Windows 8.1, using Firefox 30 beta 3, build ID: 20140508121358.