978686 - Simplify machine._jobPartNumber() now that job names are more consistent

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Now that bug 976158 has made the multi-part job names more consistent (for the jobs that TBPL supports; the release steps ones still aren't but we'll worry about them if/when they output correct branches and revisions), we can simplify the part-number regex. This will have the added bonus of meaning we don't have to hardcode the multi-part job names (this will partly fix bug 975631, though if desired, the grouping still needs to be set up).

Comment 1

[Ed Morley [:emorley]]

Attachment: Simplify machine._jobPartNumber() now that job names are more consistent

We no longer have any jobs that use the form "... jobtype 1/5" (ie part 1 out of 5).

All of our multi-part jobs end in a number, and for all of the buildernames that end in a number the only ones that are not multi-part are things like:
trobocheck2

...which ends in "[a-z]\d" so won't be caught by this regex.

Comment 2

[Ed Morley [:emorley]]

Attachment: Simplify machine._jobPartNumber() now that job names are more consistent

Actually let's switch to using a ternary now too.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8384542 [details] [diff] [review]
Simplify machine._jobPartNumber() now that job names are more consistent

Review of attachment 8384542 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 4

[Ed Morley [:emorley]]

Thanks :-)

remote:   https://hg.mozilla.org/webtools/tbpl/rev/b7a6c5411bd8