978876 - Support declined engines in meta/global on desktop

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Forking the non-UI bits of Bug 969669.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Part 1: handle declined engines in desktop Sync meta/global.

Greg, you already reviewed some of this, I think, but another skim won't hurt.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Part 2: refactor out meta/global upload. v1

Should be trivial.

Comment 3

[Richard Newman [:rnewman]]

This should be tracking 29; it's forked from Bug 969669 (which should now track 30), and parallels Bug 969672 (which tracks Fennec 29).

Needs to land with the first public release of Sync 1.5, else clients without it will fail to update or preserve the correct metadata, ultimately leading to incorrect prompting. (And it's a protocol change, and those should all land before the protocol escapes into the wild.)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Can you give a more specific example of the impact of this bug, from a user perspective? Not sure what you mean by "incorrect prompting", how likely that is to occur, in which scenarios, etc.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

E.g, would this fix bug 978876 or bug 692620?

Comment 6

[Richard Newman [:rnewman]]

Your first bug number is this bug.

Re the second: it would allow us to turn that situation into a detectible (and recoverable) failure, with or without user involvement.

Incorrect prompting: if we ship this bug in anything later than 29 (and we're already going to do this to current Nightly and Aurora users), we will at some future point (30 or 31) show a big doorhanger telling them that they could be syncing some things that they're not currently syncing, even though they explicitly chose not to sync those things.

Furthermore, we would have to do additional work to not keep screwing up like that (i.e., asking them again every time their meta/global changes) if they continue to sync with Firefox 29, because 29 wouldn't be following the spec.


Honestly, I'm going to ask for Aurora or Beta approval to land this change regardless, and expect it to be given in order to address other work items.

There's no value in tracking *for me*, so feel free to track or not according to whether there's value in it for you.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Tracking for now

Comment 8

[Richard Newman [:rnewman]]

Ping, gps? I'm hoping to land this week.

Comment 9

[Richard Newman [:rnewman]]

   https://hg.mozilla.org/integration/fx-team/rev/e427640a8060
   https://hg.mozilla.org/integration/fx-team/rev/777847816cb9
   https://hg.mozilla.org/integration/fx-team/rev/1767b08fd43a
   https://hg.mozilla.org/integration/fx-team/rev/8b53fb541235

Reviewed in the pre-fork bug, with some additions reviewed over my shoulder by markh.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e427640a8060
https://hg.mozilla.org/mozilla-central/rev/777847816cb9
https://hg.mozilla.org/mozilla-central/rev/1767b08fd43a
https://hg.mozilla.org/mozilla-central/rev/8b53fb541235

Comment 11

[Richard Newman [:rnewman]]

Comment on attachment 8385876 [details] [diff] [review]
Part 1: handle declined engines in desktop Sync meta/global.

(Request for all four parts.)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Old Sync protocol omissions.

User impact if declined: 
  Future Firefox releases will have difficulty correctly responding to client errors around datatype selection, differences in capabilities between clients, and future engine additions. Declining this uplift will also result in post-GA protocol churn, which is generally undesirable.

Testing completed (on m-c, etc.): 
  Been baking for a day or two. Manually tested. Unit-tested.

Risk to taking this patch (and alternatives if risky): 
  Should be slim. Failures are likely to be limited to errors in recording of declined engines themselves, which is a risk I consider acceptable.

String or IDL/UUID changes made by this patch:
  None.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4a52af0e7583
https://hg.mozilla.org/releases/mozilla-aurora/rev/079b6fdf34c6
https://hg.mozilla.org/releases/mozilla-aurora/rev/20d778429082
https://hg.mozilla.org/releases/mozilla-aurora/rev/9ddefe5e8915

Comment 13

[Richard Newman [:rnewman]]

Docs:

https://github.com/mozilla-services/docs/commit/d078169a0e1677f0e282a8de96bf994f095e5541