979078 - SHA-256 license distribution with binary

Status: RESOLVED FIXED

(mozilla.org :: Licensing, task)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Copyright notice

With the patches in bug 915312, I hope to introduce an external SHA-256 library into the source tree with the attached licensing notice.

Condition #1 (distribution of the copyright notice with the source code) should be satisfied as this notice is preserved in the source code.

However, I'm not sure what to do about condition #2 (distribution of the attached copyright notice with the distributed binary) - how should this be followed?

Comment 1

[Gervase Markham [:gerv]]

You add the license block to about:license (toolkit/content/license.html), in the same order and manner as existing blocks. Put up a patch here and I'll review it.

Gerv

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Add pbkdf2_sha256 license to about:license.

I noticed that bspatch has a similar license (also Colin Percival) and that this license is based off of the FreeBSD license, if that changes how it should be represented.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Bug 915312 will land the files mentioned in the license.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Just want to note that bug 915312 has landed on fx-team.

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 8386197 [details] [diff] [review]
Add pbkdf2_sha256 license to about:license.

This bug should really have blocked the landing bug.

r=gerv.

Gerv

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Gervase Markham [:gerv] from comment #5)
> This bug should really have blocked the landing bug.

Gah, that makes too much sense! Sorry about that!

https://hg.mozilla.org/integration/fx-team/rev/64f5828568e7

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64f5828568e7

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

bug 915312 was uplifted to Aurora (29) so this needs to be uplifted too. Moving product and component (temporarily) to allow for uplift flags.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8386197 [details] [diff] [review]
Add pbkdf2_sha256 license to about:license.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
  bug 915312 landed external library code

User impact if declined:
  We'd be breaking the license contained in the external library code

Testing completed (on m-c, etc.): N/A

Risk to taking this patch (and alternatives if risky): 
  None

String or IDL/UUID changes made by this patch: N/A

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/04afc61d6dc2

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Resetting component (see comment 8).