979130 - [System app] Turn wifi into power save mode while screen off with wifi lock held.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Currently holding wifi lock by |navigator.requestWakeLock('wifi')| will keep wifi up while screen is off, which might consume much battery.
Keep wifi up and turn into power save mode by |wifiManager.setPowerSavingMode()| could save more pattery.
Also we are trying to handle the wifi lock state change while screen is off.

Note that holding wifi lock doesn't imply holding CPU lock.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Pull Request

1. Enable wifi power save mode instead of turning wifi off while screen is off and wifi wake lock is held. If wifi wake lock is held after wifi is turn off by screen off, it will enable wifi and turn it into power save mode.
2. Disable wifi power save mode while screen on if its power save mode is enabled by 1.
3. Add CPU lock to protect whole process.
4. Clear timeout after cpu lock is unlocked, so it won't be called again.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8385923 [details] [review]
Pull Request

Please add unit test for what you added,
especially to make sure all cpu wake lock is unlocked.

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8385923 [details] [review]
Pull Request

1. Fix unit test error.
2. Add unit test for wifi wake lock.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8385923 [details] [review]
Pull Request

Let's land on master next week.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/9e1b16f8a313bbdc2e9441ba07f620716e5fdd58

Comment 7

[Michael Vines [:m1] [:evilmachines]]

Can we uplift this to v1.4 please.  This has been raised as a significant Wifi power issue by test folks since v1.3.  Now that we have a fix, we shouldn't wait for the next train given that we have test folks engaged now to validate the fix.

Comment 8

[Preeti Raghunath(:Preeti)]

1.4+ for Wifi betterness

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/26432916d10434103a822f17be4624a342cadfba