Closed Bug 979199 Opened 6 years ago Closed 6 years ago
Store should not dispatch events when the window is destroyed
Comment on attachment 8385185 [details] [diff] [review] patch Can you please add a test for this?
Attachment #8385185 - Flags: review?(ehsan) → review+
I cannot because it's a timing issue.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
baku and I discussed this on IRC and taking this allows us to more cleanly fix bug 985042 => 1.3+.
blocking-b2g: --- → 1.3+
Comment on attachment 8385185 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: DataStore will try to read data from a dead window. Risk to taking this patch (and alternatives if risky): none
Attachment #8385185 - Flags: approval-mozilla-b2g28?
Attachment #8385185 - Flags: approval-mozilla-b2g28? → approval-mozilla-b2g28+
This had to be backed out along with bug 985042 because one of the two broke mochitest-2 datastore tests on at least Windows: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/92403aa0ab40 https://tbpl.mozilla.org/php/getParsedLog.php?id=36629842&tree=Mozilla-B2g28-v1.3
I wonder if we need bug 976311 on b2g28 as well. Try will say! https://tbpl.mozilla.org/?tree=Try&rev=7ffa2d9b27cf
Yup, that was the problem.
You need to log in before you can comment on or make changes to this bug.