979199 - DataStore should not dispatch events when the window is destroyed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

See bug 976311 comment 8

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=adc06a17eba3

Comment 3

[(no longer active)]

Comment on attachment 8385185 [details] [diff] [review]
patch

Can you please add a test for this?

Comment 4

[Andrea Marchesini [:baku]]

I cannot because it's a timing issue.

Comment 5

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab74cf1deced

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab74cf1deced

Comment 7

[Andrew Overholt [:overholt]]

baku and I discussed this on IRC and taking this allows us to more cleanly fix bug 985042 => 1.3+.

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8385185 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: DataStore will try to read data from a dead window.
Risk to taking this patch (and alternatives if risky): none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/f95d067e819a

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This had to be backed out along with bug 985042 because one of the two broke mochitest-2 datastore tests on at least Windows:
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/92403aa0ab40

https://tbpl.mozilla.org/php/getParsedLog.php?id=36629842&tree=Mozilla-B2g28-v1.3

Comment 11

[Ryan VanderMeulen [:RyanVM]]

I wonder if we need bug 976311 on b2g28 as well. Try will say!
https://tbpl.mozilla.org/?tree=Try&rev=7ffa2d9b27cf

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Yup, that was the problem.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/80115e03e0cb