Closed Bug 985042 Opened 6 years ago Closed 6 years ago

DataStore.jsm never removes its inner-window-destroyed observer

Categories

(Core :: DOM: Core & HTML, defect, P1)

24 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla31
blocking-b2g 1.3+
Tracking Status
firefox29 --- wontfix
firefox30 --- fixed
firefox31 --- fixed
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: mccr8, Assigned: baku)

References

Details

(Keywords: perf, Whiteboard: [c=memory p= s=2014.03.28 u=1.3] [MemShrink:P2][qa-])

Attachments

(1 file)

Fabrice pointed out in bug 981871 that DataStore.jsm adds an observer for "inner-window-destroyed" but never removes it.  That seems bad.
Assignee: nobody → amarchesini
Attachment #8393040 - Flags: review?(ehsan)
Attachment #8393040 - Flags: review?(ehsan) → review+
Whiteboard: [MemShrink] → [MemShrink:P2]
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/34d970dcb450
Whiteboard: [MemShrink:P2] → [MemShrink:P2][fixed-in-fx-team]
fun, double-landed
https://hg.mozilla.org/mozilla-central/rev/34d970dcb450
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [MemShrink:P2][fixed-in-fx-team] → [MemShrink:P2]
Target Milestone: --- → mozilla31
(v1.3+ as this bug blocks a v1.3+ bug)
blocking-b2g: --- → 1.3+
Please request approval-mozilla-b2g28 on this patch when it is ready for uplift.
Flags: needinfo?(amarchesini)
(In reply to Carsten Book [:Tomcat] from comment #6)
> https://hg.mozilla.org/mozilla-central/rev/3e5ef72102e4

This does not apply cleanly on v1.3. Can we get a patch for v1.3 quickly. It will help me to confirm https://bugzilla.mozilla.org/show_bug.cgi?id=981871#c76 quickly.
(In reply to Tapas Kumar Kundu from comment #9)
> (In reply to Carsten Book [:Tomcat] from comment #6)
> > https://hg.mozilla.org/mozilla-central/rev/3e5ef72102e4
> 
> This does not apply cleanly on v1.3. Can we get a patch for v1.3 quickly. It
> will help me to confirm
> https://bugzilla.mozilla.org/show_bug.cgi?id=981871#c76 quickly.

Which version of gecko do we use for 1.3 ?
Flags: needinfo?(amarchesini) → needinfo?(tkundu)
(In reply to Andrea Marchesini (:baku) from comment #10)
> Which version of gecko do we use for 1.3 ?

http://hg.mozilla.org/releases/mozilla-b2g28_v1_3/
Flags: needinfo?(tkundu)
I'll attach a new patch in 1 hour.
Depends on: 979199
We should uplift bug 979199.
Actually bug 979199 is already 1.3+ but it has to land first.
No longer blocks: 981871
Depends on: 981871
Blocks: 981871
No longer depends on: 981871
I don't see a 1.3+ there? And even still, *all* patches need approval to land at this point. So please request 1.3 blocking status on bug 979199 and request approval-mozilla-b2g28 on the patch there.
Attachment #8393040 - Flags: approval-mozilla-b2g28+
> https://tbpl.mozilla.org/php/getParsedLog.php?id=36629842&tree=Mozilla-B2g28-
> v1.3

I'm lost. is it backed out or not? What about comment 18?
Flags: needinfo?(amarchesini)
It was re-landed along with bug 976311 and stuck.
Keywords: perf
Priority: -- → P1
Whiteboard: [MemShrink:P2] → [c=memory p= s=2014.03.28 u=1.3] [MemShrink:P2]
Whiteboard: [c=memory p= s=2014.03.28 u=1.3] [MemShrink:P2] → [c=memory p= s=2014.03.28 u=1.3] [MemShrink:P2][qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.