Closed Bug 979207 Opened 11 years ago Closed 7 years ago

Intermittent browser_968447_bookmarks_toolbar_items_in_panel.js | Test timed out | Found a browser window after previous test timed out

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
x86
Linux
Type:
defect
Points:
2

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox30 --- wontfix
firefox31 --- fixed
firefox32 --- disabled
firefox33 --- disabled
firefox-esr24 --- unaffected

People

(Reporter: cbook, Unassigned)

References

(
URL
)

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled on Linux])

Attachments

(3 files)

add logging and better yielding to browser_968447_bookmarks_toolbar_items_in_panel.js,
2.56 KB, patch
mikedeboer
: review+
Gijs
: checkin+
Details | Diff | Splinter Review
add PanelUI panelshown listener before showing panel,
1.68 KB, patch
mikedeboer
: review+
Gijs
: checkin+
Details | Diff | Splinter Review
add some logging to see if the popup is getting closed while opening,
2.11 KB, patch
mconley
: review+
Gijs
: checkin+
Details | Diff | Splinter Review
Ubuntu ASAN VM 12.04 x64 mozilla-inbound opt test mochitest-browser-chrome on 2014-03-03 23:28:46 PST for push dd9cf2bef693 slave: tst-linux64-ec2-302 https://tbpl.mozilla.org/php/getParsedLog.php?id=35585598&tree=Mozilla-Inbound TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Test timed out TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found a browser window after previous test timed out
Summary: Intermittent | browser_968447_bookmarks_toolbar_items_in_panel.js | Test timed out TEST-UNEXPECTED-FAIL | → Intermittent browser_968447_bookmarks_toolbar_items_in_panel.js | Test timed out | Found a browser window after previous test timed out
This is actually really frequent, and we should try to fix this. I don't know how this got through review before, but PanelUI.hide doesn't return a promise so yielding it isn't useful (and no, I don't think we should change that right now in order to try and fix this test). We should also be waiting for delayedStartup to have fired after that, when opening a new window. Note that this is failing on Linux, but nowhere else, and that it even happens on pgo and opt builds. I've not figured out exactly why, but this will at least add more logging and figure out what's going wrong in terms of what we're timing out on.
Attachment #8433284 - Flags: review?(mdeboer)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8433284 [details] [diff] [review] add logging and better yielding to browser_968447_bookmarks_toolbar_items_in_panel.js, Review of attachment 8433284 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! I'm not aware of yield icw functions not returning a Promise, but the extensive logging and other changes look good and I'm hopeful that this'll fix the intermittents.
Attachment #8433284 - Flags: review?(mdeboer) → review+
Attachment #8433284 - Flags: checkin+
Marco, can you add this one as well? Thanks!
Flags: needinfo?(mmucci)
Whiteboard: p=2 [qa-]
Flags: firefox-backlog+
Added to Iteration 32.3
Flags: needinfo?(mmucci)
Whiteboard: p=2 [qa-] → p=2 s=it-32c-31a-30b.3 [qa-]
Seeing as this now has another intermittent bug filed against it (bug 1020803), let's close this and track the remaining issues there...
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
See Also: → 1020803
Status: RESOLVED → VERIFIED
Keywords: leave-open
status-firefox30: --- → wontfix
status-firefox31: --- → affected
status-firefox32: --- → fixed
status-firefox-esr24: --- → unaffected
Depends on: 1020803
Target Milestone: --- → Firefox 32
Bug 1020803 tracks a different failure mode than this bug, and we're still hitting both. Reopening.
Status: VERIFIED → REOPENED
status-firefox31: fixed → affected
status-firefox32: fixed → affected
Resolution: FIXED → ---
Target Milestone: Firefox 32 → ---
So I ran into this. I don't know for sure that this is the issue, but I do know that we should be fixing it regardless - and it's plausible that a race between popupshown and our adding the listener is it, considering it now mostly fails on PGO and opt builds, and not on debug builds anymore (the try push I suspect doesn't have the earlier fix here).
Attachment #8436791 - Flags: review?(mdeboer)
Whiteboard: p=2 s=it-32c-31a-30b.3 [qa-] → p=2 s=33.1 [qa-]
Status: REOPENED → ASSIGNED
Comment on attachment 8436791 [details] [diff] [review] add PanelUI panelshown listener before showing panel, Review of attachment 8436791 [details] [diff] [review]: ----------------------------------------------------------------- Alright, fine with me. I hope this works! (I hate saying that, but that's the thing with intermittents, isn't it?)
Attachment #8436791 - Flags: review?(mdeboer) → review+
Comment on attachment 8436791 [details] [diff] [review] add PanelUI panelshown listener before showing panel, (In reply to Mike de Boer [:mikedeboer] from comment #163) > Comment on attachment 8436791 [details] [diff] [review] > add PanelUI panelshown listener before showing panel, > > Review of attachment 8436791 [details] [diff] [review]: > ----------------------------------------------------------------- > > Alright, fine with me. I hope this works! (I hate saying that, but that's > the thing with intermittents, isn't it?) Quite so. remote: https://hg.mozilla.org/integration/fx-team/rev/6ab693f017ef
Attachment #8436791 - Flags: checkin+
I'm now just seeing the other instances (1020803) being hit, so I'm closing this one.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
status-firefox33: --- → fixed
Target Milestone: --- → Firefox 33
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
This bug doesn't want to die. So now we're failing at opening the popup in the new window. Don't know why. Let's see if this helps (I don't know if console.trace ends up in the log, but I asked in #devtools and nobody could tell me something better...)
Attachment #8440685 - Flags: review?(mconley)
Comment on attachment 8440685 [details] [diff] [review] add some logging to see if the popup is getting closed while opening, Review of attachment 8440685 [details] [diff] [review]: ----------------------------------------------------------------- r=me, assuming one of the following: 1) You ensure that console.trace() outputs to stdout or stderr for log capture during a mochitest-browser run. 2) If (1) doesn't work out, you use something like info(new Error().stack). ::: browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js @@ +29,5 @@ > let newWin = yield openAndLoadWindow({}, true); > > info("Waiting for panel in new window to open"); > + let hideTrace = function() { > + console.trace(); Maybe info(new Error().stack) would be a better choice - that'd surely show up in the log.
Attachment #8440685 - Flags: review?(mconley) → review+
remote: https://hg.mozilla.org/integration/fx-team/rev/8e5bd129c501 w/ new Error().stack Thanks for the suggestion!
Keywords: leave-open
Attachment #8440685 - Flags: checkin+
Status: REOPENED → ASSIGNED
Iteration: --- → 33.2
Points: --- → 2
QA Whiteboard: [qa-]
Whiteboard: p=2 s=33.1 [qa-]
Hi Gijs, in the planning meeting you mentioned this bug is blocked. From what you know should we remove Bug 979207 from the iteration?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Marco Mucci [:MarcoM] from comment #288) > Hi Gijs, in the planning meeting you mentioned this bug is blocked. From > what you know should we remove Bug 979207 from the iteration? I expect this is blocked on bug 1026310, which is also slated for this iteration, so I think we can keep it for now and see what happens once bug 1026310 is fixed.
Flags: needinfo?(gijskruitbosch+bugs)
Removed from Iteration 33.2
Iteration: 33.2 → ---
Disabled browser_968447_bookmarks_toolbar_items_in_panel.js on Linux for intermittent failures until bug 1026310 is fixed: https://hg.mozilla.org/integration/mozilla-inbound/rev/94315f006638
Whiteboard: [test disabled on Linux]
Added to Iteration 33.2
Iteration: --- → 33.2
Iteration: 33.2 → 33.3
(In reply to Ed Morley [:edmorley UTC+0] from comment #474) > Disabled browser_968447_bookmarks_toolbar_items_in_panel.js on Linux for > intermittent failures until bug 1026310 is fixed: > https://hg.mozilla.org/integration/mozilla-inbound/rev/94315f006638 https://hg.mozilla.org/releases/mozilla-aurora/rev/4eeb71654d66
status-firefox32: fixed → disabled
status-firefox33: fixed → disabled
Target Milestone: Firefox 33 → ---
Removed from Iteration 33.3
Status: ASSIGNED → NEW
Iteration: 33.3 → ---
Assignee: gijskruitbosch+bugs → nobody
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
The leave-open keyword is there and there is no activity for 6 months. :Gijs, maybe it's time to close this bug?
Flags: needinfo?(gijskruitbosch+bugs)
Status: NEW → RESOLVED
Closed: 11 years ago → 7 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: