Closed Bug 1020803 Opened 5 years ago Closed 5 years ago

Intermittent browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds. | Found an unexpected browser window at the end of test run

Categories

(Firefox :: Toolbars and Customization, defect)

x86
Linux
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 33
Tracking Status
firefox31 --- unaffected
firefox32 --- fixed
firefox33 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: cbook, Assigned: Gijs)

References

()

Details

(Keywords: intermittent-failure, Whiteboard: p=2 s=33.1 [qa-])

Ubuntu ASAN VM 12.04 x64 fx-team opt test mochitest-browser-chrome-1 on 2014-06-04 19:51:36 PDT for push 18925acdcbbf

slave: tst-linux64-spot-135

https://tbpl.mozilla.org/php/getParsedLog.php?id=41083925&tree=Fx-Team

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
See Also: → 979207
Summary: Intermittent browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds. → Intermittent browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds. | Found an unexpected browser window at the end of test run
Marco, can you add this one? :-)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(mmucci)
Whiteboard: p=2 s=33.1 [qa-]
Added to Iteration 33.1
Flags: needinfo?(mmucci)
So there's a trivial fix for the orange, I suspect, of adding the panel hidden listener earlier... the problem I have with this is that unlike in bug 1015617, I don't know why the panel would close immediately... (in bug 1015617, it would be because the drop would cause it to close, I believe)

This failure is only hitting debug tests. I've already changed the code to wait for delayed startup. I don't know what else is happening that's causing the panel to close, but I suspect something is stealing focus in the new window... like the search box on about:home . Hmm.

So in fact, I'm actually just going to check if the panel is closed before making us wait for the panel hidden event. That should be effective, and the only reason I'm not doing it everywhere (ie in head.js) is because unless we're opening a panel right after opening the window, or there's some other reason for the popup closing (cf. first paragraph), this shouldn't be happening.
Flags: firefox-backlog+
https://hg.mozilla.org/mozilla-central/rev/791b1095d0f8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Egh, should have left in a leave-open. Let's leave this open for a few days to ensure there's nothing left.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.