1020803 - Intermittent browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds. | Found an unexpected browser window at the end of test run

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Carsten Book [:Tomcat]]

Ubuntu ASAN VM 12.04 x64 fx-team opt test mochitest-browser-chrome-1 on 2014-06-04 19:51:36 PDT for push 18925acdcbbf

slave: tst-linux64-spot-135

https://tbpl.mozilla.org/php/getParsedLog.php?id=41083925&tree=Fx-Team

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.

Comment 1

[Legacy TBPL/Treeherder Robot]

Tomcat
https://tbpl.mozilla.org/php/getParsedLog.php?id=41192397&tree=Fx-Team
Ubuntu VM 12.04 fx-team debug test mochitest-browser-chrome-1 on 2014-06-06 02:06:32
revision: 60a2f2f69feb
slave: tst-linux32-spot-514

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run

Comment 2

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=41341979&tree=Mozilla-Inbound
Ubuntu VM 12.04 mozilla-inbound debug test mochitest-browser-chrome-1 on 2014-06-09 01:11:15
revision: c3696dc11743
slave: tst-linux32-spot-640

ImportError: No module named pygtk
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_popupNotification.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run

Comment 3

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=41394974&tree=Mozilla-Inbound
Ubuntu VM 12.04 x64 mozilla-inbound debug test mochitest-browser-chrome-1 on 2014-06-09 16:03:54
revision: 8ed25ba82a9d
slave: tst-linux64-spot-1028

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run
Assertion failure: JS_IsShutDown() (Proxy handler destructor called with engine running?), at /builds/slave/m-in-l64-d-0000000000000000000/build/js/src/jsproxy.cpp:91
Assertion failure: JS_IsShutDown() (Proxy handler destructor called with engine running?), at /builds/slave/m-in-l64-d-0000000000000000000/build/js/src/jsproxy.cpp:91
TEST-UNEXPECTED-FAIL | Shutdown | application timed out after 330 seconds with no output
TEST-UNEXPECTED-FAIL | Shutdown | application terminated with exit code 6
PROCESS-CRASH | Shutdown | application crashed [Unknown top frame]
PROCESS-CRASH | Shutdown | application crashed [@ libpthread-2.15.so + 0x9148]
Return code: 1

Comment 4

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=41422013&tree=B2g-Inbound
Ubuntu VM 12.04 b2g-inbound debug test mochitest-browser-chrome-1 on 2014-06-10 00:34:35
revision: 38e44f89c1c0
slave: tst-linux32-spot-485

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run

Comment 5

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=41468873&tree=Try
Ubuntu VM 12.04 try debug test mochitest-browser-chrome-1 on 2014-06-10 12:32:21
revision: 4fcb53d5f031
slave: tst-linux32-spot-428

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run

Comment 6

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=41513612&tree=Mozilla-Inbound
Ubuntu VM 12.04 mozilla-inbound debug test mochitest-browser-chrome-1 on 2014-06-11 03:16:29
revision: e0ee3ba4a102
slave: tst-linux32-spot-592

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run

Comment 7

[:Gijs (he/him)]

Marco, can you add this one? :-)

Comment 8

[Marco Mucci [:MarcoM]]

Added to Iteration 33.1

Comment 9

[:Gijs (he/him)]

So there's a trivial fix for the orange, I suspect, of adding the panel hidden listener earlier... the problem I have with this is that unlike in bug 1015617, I don't know why the panel would close immediately... (in bug 1015617, it would be because the drop would cause it to close, I believe)

This failure is only hitting debug tests. I've already changed the code to wait for delayed startup. I don't know what else is happening that's causing the panel to close, but I suspect something is stealing focus in the new window... like the search box on about:home . Hmm.

So in fact, I'm actually just going to check if the panel is closed before making us wait for the panel hidden event. That should be effective, and the only reason I'm not doing it everywhere (ie in head.js) is because unless we're opening a panel right after opening the window, or there's some other reason for the popup closing (cf. first paragraph), this shouldn't be happening.

Comment 10

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/791b1095d0f8

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/791b1095d0f8

Comment 12

[:Gijs (he/him)]

Egh, should have left in a leave-open. Let's leave this open for a few days to ensure there's nothing left.

Comment 13

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=41537281&tree=Mozilla-Inbound
Ubuntu VM 12.04 x64 mozilla-inbound debug test mochitest-browser-chrome-1 on 2014-06-11 10:08:53
revision: 2152e0e62c5a
slave: tst-linux64-spot-039

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/290cb33fc017

Comment 15

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-03T11:59:50
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-esr31&job_id=41700
repository: mozilla-esr31
who: philringnalda[at]gmail[dot]com
machine: tst-linux32-spot-762
buildname: Ubuntu VM 12.04 mozilla-esr31 debug test mochitest-browser-chrome-1
revision: d13776405921

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run

Comment 16

[Legacy TBPL/Treeherder Robot]

submit_timestamp: 2015-01-03T12:08:00
log: https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-esr31&job_id=41206
repository: mozilla-esr31
who: philringnalda[at]gmail[dot]com
machine: tst-linux32-spot-281
buildname: Ubuntu VM 12.04 mozilla-esr31 debug test mochitest-browser-chrome-1
revision: 1be092ad0bae

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run

Comment 17

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-esr31&job_id=74085
repository: mozilla-esr31
start_time: 2015-06-05T09:38:39
who: rvandermeulen[at]mozilla[dot]com
machine: tst-linux32-spot-1016
buildname: Ubuntu VM 12.04 mozilla-esr31 debug test mochitest-browser-chrome-1
revision: ec83c431fcec

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Uncaught exception - Panel did not hide within 20 seconds.
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968447_bookmarks_toolbar_items_in_panel.js | Found an unexpected browser window at the end of test run