979242 - Intermittent | valgrind-test | 21,008 (20,992 direct, 16 indirect) bytes in 1 blocks are definitely lost at calloc / xcb_connect_to_fd / xcb_connect_to_display_with_auth_info / _XConnectXCB

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Carsten Book [:Tomcat]]

Linux x86-64 mozilla-inbound valgrind on 2014-03-03 20:36:46 PST for push af11210cba85

slave: bld-linux64-spot-364

https://tbpl.mozilla.org/php/getParsedLog.php?id=35576351&tree=Mozilla-Inbound

TEST-UNEXPECTED-FAIL | valgrind-test | 21,008 (20,992 direct, 16 indirect) bytes in 1 blocks are definitely lost at calloc / xcb_connect_to_fd / xcb_connect_to_display_with_auth_info / _XConnectXCB

Comment 1

[Nicholas Nethercote [:njn] (On Long Service Leave)]

Attachment: Suppress leak in xcb_connect_to_fd detected by Valgrind.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 8387381 [details] [diff] [review]
Suppress leak in xcb_connect_to_fd detected by Valgrind.

Is this diff'ed against the correct changeset?

I checked that it does not seem to patch correctly at http://hg.mozilla.org/mozilla-central/annotate/b0e7f63c2138/build/valgrind/x86_64-redhat-linux-gnu.sup which is tip right now. (Moreover I couldn't find the bug 850134 in the source tree (from the context).)

Nonetheless, the changed lines itself are r=me once you get a patch that can actually land on m-c tip properly.

Comment 3

[Nicholas Nethercote [:njn] (On Long Service Leave)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba6348311052

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ba6348311052