Closed
Bug 979318
Opened 11 years ago
Closed 11 years ago
Plugin overlays are still layered over other elements
Categories
(Core Graveyard :: Plug-ins, defect, P3)
Core Graveyard
Plug-ins
Tracking
(firefox32 verified)
VERIFIED
FIXED
mozilla32
Tracking | Status | |
---|---|---|
firefox32 | --- | verified |
People
(Reporter: gfritzsche, Assigned: jaws)
References
()
Details
(Whiteboard: p=2 s=it-32c-31a-30b.3 [qa!] )
Attachments
(4 files, 3 obsolete files)
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
In some cases we still layer the plugin overlay on top after bug 976769.
Reporter | ||
Comment 2•11 years ago
|
||
This stops the overlay being on top at the URL, but still has problems with the closeIcon. No value for position is helpful here:
* relative: closeIcon still over menu
* absolute: closeIcon at top right of page
* remove position specification: can't get closeIcon positioned using top and right
jaws, do you have an idea on what's going on here or a better option?
Attachment #8385366 -
Flags: feedback?(jaws)
Reporter | ||
Comment 3•11 years ago
|
||
Reporter | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Any positioned content creates its own stacking context, so anything that uses relative or absolute positioning will then be positioned over DOM nodes that are earlier in the tree but also have stacking contexts. We could try making it less common by giving things a *negative* z-index, but I'm not sure that won't introduce other issues.
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8385366 [details] [diff] [review]
WIP
Yeah, I don't know what we can realistically do here. I actually think it is best how it is currently working, since we have the close icon the user can get rid of it.
Attachment #8385366 -
Flags: feedback?(jaws) → feedback-
Reporter | ||
Comment 7•11 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #6)
> I actually think it is
> best how it is currently working, since we have the close icon the user can
> get rid of it.
Well, per the changes in bug 853973 we only hide the overlay contents, not the overlay itself - .mainBox & .visible handling here:
http://hg.mozilla.org//mozilla-central/annotate/e5b09585215f/toolkit/mozapps/plugins/content/pluginProblemContent.css#l61
If we don't want to try to respect the layering in the page, we could also just make the "close overlay" buttons hide the element itself or all of the overlay again.
Reporter | ||
Comment 8•11 years ago
|
||
How about this then? This hides the whole overlay on close icon click, but shows it again when needed (like click-to-play => activate => crash or re-block).
Note:
* also did some cleanup/consolidation while i was there
* will add test if this is acceptable
Attachment #8385366 -
Attachment is obsolete: true
Attachment #8386683 -
Flags: feedback?(jaws)
Assignee | ||
Comment 9•11 years ago
|
||
Sorry for the run around here. This fixes for me the first patch that you posted. What do you think about it?
Attachment #8386683 -
Attachment is obsolete: true
Attachment #8386683 -
Flags: feedback?(jaws)
Attachment #8394159 -
Flags: review?(georg.fritzsche)
Assignee | ||
Updated•11 years ago
|
Attachment #8394159 -
Flags: review?(georg.fritzsche) → feedback?(georg.fritzsche)
Reporter | ||
Comment 10•11 years ago
|
||
Sorry, i think i will only get here next week.
Reporter | ||
Updated•11 years ago
|
Flags: firefox-backlog?
Updated•11 years ago
|
Flags: firefox-backlog? → firefox-backlog+
Reporter | ||
Comment 11•11 years ago
|
||
Comment on attachment 8394159 [details] [diff] [review]
Patch - Fixed first attempt
Sorry this slipped by for a while.
I'm not confident about evaluating CSS changes, but the behavior seems fine with the URLs in the cluster of bugs here and we do show notification bars for non-visible plugins now.
Attachment #8394159 -
Flags: feedback?(georg.fritzsche) → feedback+
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 8394159 [details] [diff] [review]
Patch - Fixed first attempt
Review of attachment 8394159 [details] [diff] [review]:
-----------------------------------------------------------------
Gijs, are you comfortable reviewing the CSS changes here?
Attachment #8394159 -
Flags: review?(gijskruitbosch+bugs)
Reporter | ||
Updated•11 years ago
|
Assignee: georg.fritzsche → jaws
Reporter | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 13•11 years ago
|
||
Comment on attachment 8394159 [details] [diff] [review]
Patch - Fixed first attempt
Review of attachment 8394159 [details] [diff] [review]:
-----------------------------------------------------------------
display: table?
*twitch*
But yeah, this works. Obvious assumption here is that there's no other positioned content relying on that position: relative, which there doesn't seem to be. r=me
Attachment #8394159 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 14•11 years ago
|
||
Comment 15•11 years ago
|
||
Note that this makes the text and icon off-center. Adding -moz-margin-start: -20px fixes this. r=me with that. Oops. :-\
Assignee | ||
Comment 16•11 years ago
|
||
Carrying forward r+ from Gijs, with -moz-margin-start rule added.
Attachment #8394159 -
Attachment is obsolete: true
Attachment #8432611 -
Flags: review+
Assignee | ||
Comment 17•11 years ago
|
||
Marco, can you please add this to the current iteration. This was old work which had been forgotten about in a review queue.
Flags: needinfo?(mmucci)
Whiteboard: p=2 [qa+]
Comment 18•11 years ago
|
||
Added to Iteration 32.3
Flags: needinfo?(mmucci)
Whiteboard: p=2 [qa+] → p=2 s=it-32c-31a-30b.3 [qa+]
Assignee | ||
Comment 19•11 years ago
|
||
Whiteboard: p=2 s=it-32c-31a-30b.3 [qa+] → p=2 s=it-32c-31a-30b.3 [qa+] [fixed-in-fx-team]
Comment 20•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: p=2 s=it-32c-31a-30b.3 [qa+] [fixed-in-fx-team] → p=2 s=it-32c-31a-30b.3 [qa+]
Target Milestone: --- → mozilla32
Updated•11 years ago
|
QA Contact: paul.silaghi
Comment 21•11 years ago
|
||
http://oharenoise.org/
http://wiesenmarkt.at/news.php
http://www.eleanorlaing.com/
http://www.huffingtonpost.com/2012/01/09/taiwan-garbage-trucks-music_n_1195020.html#comments
The menu is properly displayed, 32.0a1 (2014-06-04), Win 7 x64, Ubuntu 12.10, OS X 10.8.5
Status: RESOLVED → VERIFIED
status-firefox32:
--- → verified
Whiteboard: p=2 s=it-32c-31a-30b.3 [qa+] → p=2 s=it-32c-31a-30b.3 [qa!]
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•