Closed Bug 979405 Opened 10 years ago Closed 10 years ago

bing pc and form codes are incorrect

Categories

(Firefox for Metro Graveyard :: General, defect, P1)

Product:
Firefox for Metro Graveyard
Component:
General
Platform:
x86_64
Windows 8
Type:
defect

Tracking

(firefox28 verified, firefox29 verified, firefox30 verified, b2g-v1.3 fixed)

Status:
VERIFIED FIXED
Milestone:
Firefox 30
Tracking Flags:
Tracking Status
firefox28 --- verified
firefox29 --- verified
firefox30 --- verified
b2g-v1.3 --- fixed

People

(Reporter: mconnor, Assigned: mconnor)

References

Details

(Whiteboard: p=0 s=it-30c-29a-28b.3 r=ff30 [qa+])

Attachments

(1 file)

implement distinct Metro codes
10.36 KB, patch
mbrubeck
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Bug 917933 got this wrong.  I'm guessing some excellent levels of telephone game at work here.  That said, we have a table for these things now, so I'm going to get this updated.

Partner code should be MOZW and the form code should be MOZWSB.  I'm adding a different branding pref to match what we're doing for Yahoo in bug 942024 and switching the Bing plugin to use that pref instead.
Attachment #8385426 - Flags: review?(mbrubeck)
Attachment #8385426 - Flags: review?(mbrubeck) → review+
Blocks: metrobacklog
Whiteboard: [triage]
Comment on attachment 8385426 [details] [diff] [review]
implement distinct Metro codes

https://hg.mozilla.org/integration/mozilla-inbound/rev/bcc3e9304304

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: impact to revenue/measurement only
Testing completed (on m-c, etc.): tested locally.
Risk to taking this patch (and alternatives if risky): minitmal, only impacts metro partner codes, incorrect configuration will not impair functionality.
String or IDL/UUID changes made by this patch: none
Attachment #8385426 - Flags: approval-mozilla-beta?
Attachment #8385426 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/bcc3e9304304
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
QA Contact: kamiljoz
Whiteboard: [triage] → p=0 s=it-30c-29a-28b.3 r=ff30
Whiteboard: p=0 s=it-30c-29a-28b.3 r=ff30 → p=0 s=it-30c-29a-28b.3 r=ff30 [qa+]
Attachment #8385426 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 917933
Attachment #8385426 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
For testing and verification.  Reopen if any defects found.
Flags: needinfo?(kamiljoz)
Went through verification using the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-03-09-03-02-04-mozilla-central/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-03-09-00-40-03-mozilla-aurora/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/28.0b9/win32/en-US/

- Ensured that the form search code appears as "MOZSBR" under fxdesktop (Nightly, Aurora, BETA)
- Ensured that the form search code appears as "MOZWSB" under fxmetro (Nightly, Aurora, BETA)
- Ensured that the "MOZW" partner ID is being used under fxmetro (BETA)
- Ensured that the "MOZI" partner ID is being used under fxdesktop (BETA)
Status: RESOLVED → VERIFIED
status-firefox28: fixed → verified
status-firefox29: fixed → verified
status-firefox30: fixed → verified
Flags: needinfo?(kamiljoz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: