942024 - Yahoo search not using custom search codes

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

When using the Yahoo search engine through the URL bar, the search codes are identical. When you use either Google/Bing, the search codes differ from Firefox Desktop/Firefox Metro.

Examples:

Bing Search Results:
Metro: http://www.bing.com/search?q=firefox&form=MOZLBR
Desktop: http://www.bing.com/search?q=firefox&form=MOZW

Google Search Results:
Metro: https://www.google.com/search?q=firefox&ie=utf-8&oe=utf-8&client=metrofirefox
Desktop: https://www.google.ca/search?q=mozilla&ie=utf-8&oe=utf-8&rls=org.mozilla:en-US:unofficial&client=firefox-nightly&channel=fflb&gws_rd=cr&ei=xdiOUq6DMIz22AWZhYDwCA

Yahoo Search Results:
Metro: http://search.yahoo.com/search?p=firefox&ei=UTF-8&fr=
Desktop: http://search.yahoo.com/search?p=firefox&ei=UTF-8&fr=

Steps to reproduce the issue:

1) Open Firefox Desktop and switch the default search engine to Yahoo
2) Search for "firefox" through the URL bar and note the URL
3) Switch over to Firefox Desktop and type in "firefox" inside the URL bar
4) Tap on the "Yahoo" icon and note the URL (they will be identical)

If you go through the above STR in either Google/Bing, the search codes will be different.

Comment 1

[Kamil Jozwiak [:kjozwiak]]

Just wanted to double check if this behavior is expected as the other search engines have custom search codes.

Comment 2

[Karen Rudnitski [:kar]]

Let me take a look into this (by asking Joanne :)). Will get back to you ASAP.

Comment 3

[Joanne Nagel]

Ah, good point!  Let me request a separate tracking tag from Yahoo.  I will update the thread as soon as I receive it.  Thanks for catching this!  Joanne

Comment 4

[Joanne Nagel]

Here is the Metro specific search tag:  mozilla_metro_search

Comment 5

[Jim Mathies [:jimm]]

(In reply to Joanne Nagel from comment #4)
> Here is the Metro specific search tag:  mozilla_metro_search

should this replace the 'firefox' param in the p parameter?

Comment 6

[Joanne Nagel]

I'm not sure that you can use the URL for Yahoo to determine the search tag.  I believe the 'firefox' param is actually the partner code, differentiating all traffic as Mozilla's.  Then there should be another parameter that is a search code or source tag tag, similar to:  yahoo_mozilla_moz35_trans_us, which we would substitute the mozilla_metro_search code for Metro.  Looping in Kev to see if he can help.

Comment 7

[Kev Needham [:kev]]

Yahoo! uses the "fr" code for search tracking, typically. I'll work with Joanne and submit a patch here when I confirm codes.

Comment 8

[Francesco Lodolo [:flod]]

We also need to understand how much of this stuff we need to port to l10n.

Comment 9

[Jim Mathies [:jimm]]

Kev, any update on this? Also, do we need to block on aurora for this due to l10n changes or can this land on beta?

Comment 10

[Francesco Lodolo [:flod]]

Note that fixing this on l10n side will take time, so the sooner we start the better.

Comment 11

[Mike Connor [:mconnor]]

I thought I'd commented on this already, but here goes:

p= is the search term.  That shouldn't change.  fr= is partner code, which is only set for officially branded builds via firefox-branding.js

It's straightforward to add another value to that file for metro codes, and update the search plugin in Metro to use that alternative value.

Francesco, assuming existing plugins are using the same as en-US:

<MozParam name="fr" condition="pref" pref="yahoo-fr" />

This would change to

<MozParam name="fr" condition="pref" pref="yahoo-fr-metro" />

in the metro versions of the plugins, and we'd get the correct code everywhere.  Is that something we can do in relatively short order?

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Mike Connor [:mconnor] from comment #11)
> in the metro versions of the plugins, and we'd get the correct code
> everywhere.  Is that something we can do in relatively short order?

The only way to be fast is to land directly on l10n repositories and use a tracking bug, without going through patches and approvals.

Right now for Yahoo we need to fix several pending problems:
* update desktop icon with hi-dpi version
* create a yahoometrofx version

If we need to ship this with Firefox 28, we can try do it soon on beta cycle.

Comment 13

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #12)
> Right now for Yahoo we need to fix several pending problems:
> * update desktop icon with hi-dpi version
> * create a yahoometrofx versionù

For that I was also waiting for the updated icon to land (en-US still has the old one for 74px).

Comment 14

[Mike Connor [:mconnor]]

Ok, I'll get the hiDPI version we have landed ASAP, and we'll move quickly from there.

Comment 15

[Francesco Lodolo [:flod]]

Mike, I filed bug 967388 to track the l10n part of this Yahoo update. 

I'm going to fix this directly on mozilla-aurora and l10n-central, for a limited set of locales we'll try to land fixes on mozilla-beta so I'll be creating patches and asking you for review.

See bug 936198 comment 24 about the current images, while I still see the standard pref everywhere. Should I go on and use "yahoo-fr-metro" or do we need to wait?

Comment 16

[Mike Connor [:mconnor]]

As far as I can tell this is WFM except that it's the wrong code.  Taking, I have a patch.

Comment 17

[Mike Connor [:mconnor]]

Attachment: yahooMetroCode

Comment 18

[Mike Connor [:mconnor]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a20b86f52b7c

Comment 19

[Mike Connor [:mconnor]]

Comment on attachment 8374435 [details] [diff] [review]
yahooMetroCode

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new requirement for Metro
User impact if declined: no direct user impact, impacts partner tracking/revenue, other patches dependent on this will cause lost codes
Testing completed (on m-c, etc.): tested to be working
Risk to taking this patch (and alternatives if risky): minimal.
String or IDL/UUID changes made by this patch: none

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a20b86f52b7c

Comment 21

[Marco Mucci [:MarcoM]]

For testing and verification.  Reopen if any defects found.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1a7dd5f845e6
https://hg.mozilla.org/releases/mozilla-beta/rev/adde00109cc2

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/adde00109cc2

Comment 24

[Kamil Jozwiak [:kjozwiak]]

Went through the verification process using the following BETA build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/28.0b9/win32/en-US/

Went through all the available search engines under fxmetro and ensured that the correct search code are being used:
- https://www.google.com/search?q=mozilla&ie=utf-8&oe=utf-8&client=metrofirefox
- http://www.bing.com/search?q=mozilla&pc=MOZW&form=MOZWSB
- http://search.yahoo.com/search?p=mozilla&ei=UTF-8&fr=mozilla_metro_search

Went through the following test cases:

- Set all three search engines as default and searched via the about:start (Google, Bing, Yahoo)
- Used the icons under the auto search feature and ensured that the correct search codes are being used (Google, Bing, Yahoo)
- Ensured that the Desktop search plugin's were still using the correct search codes (ensured fxmetro changes didn't affect fxdesktop)

Comment 25

[Kamil Jozwiak [:kjozwiak]]

Went through the verification process using the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-03-09-03-02-04-mozilla-central/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-03-09-00-40-03-mozilla-aurora/

For the above builds, the following preference was changed:
- browser.search.param.yahoo-fr-metro

- Went through all the test cases in comment #24
- Ensured that changing the above preference didn't affect the other search engine codes
- Ensured that changing the above preference didn't affect the search codes under fxdesktop