979450 - emulator-kk builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

we need emulator-kk builds so that we don't break kitkat support for 1.4

the manifest is already in b2g-manifests, so this should be very similar to emulator-jb, except for the exact manifests used.

Comment 1

[Chris AtLee [:catlee]]

Attachment: in-tree emulator-kk configs

Comment 2

[Chris AtLee [:catlee]]

Attachment: b2g bumper config changes for emulator-kk

Comment 3

[Chris AtLee [:catlee]]

Attachment: tbpl support for emulator-kk

Comment 4

[Chris AtLee [:catlee]]

Attachment: buildbot-configs for emulator-kk

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3643c3e1e535

Comment 6

[Ed Morley [:emorley]]

(In reply to Chris AtLee [:catlee] from comment #3)
> Created attachment 8385616 [details] [diff] [review]
> tbpl support for emulator-kk

in production :-)

Comment 7

[Rail Aliiev [:rail]]

in production

Comment 8

[Phil Ringnalda (:philor)]

Comment on attachment 8385680 [details] [diff] [review]
buildbot-configs for emulator-kk

>+# MERGE DAY: emulator-kk is for B2G 1.3+
>+for branch in BRANCHES:
>+    if branch not in ('mozilla-central', 'mozilla-inbound', 'b2g-inbound', 'try'):
>+        if 'emulator-kk' in BRANCHES[branch]['platforms']:
>+            del BRANCHES[branch]['platforms']['emulator-kk']
>+        if 'emulator-kk-debug' in BRANCHES[branch]['platforms']:
>+            del BRANCHES[branch]['platforms']['emulator-kk-debug']
>+

Did you intend this as something that's going to run hidden? If you wanted visible, then you wanted all trunk trees, not just a few.

Comment 9

[Phil Ringnalda (:philor)]

Oh, the periodic hack around the visibility requirements. Interesting.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8385616 [details] [diff] [review]
tbpl support for emulator-kk

If I had realized that these were going to be scheduled as periodic (instead of per-push like every other emulator build), I would have given this an r- since it doesn't actually work in the periodic case. But since this is already landed and the builds are enabled, I pushed a follow-up instead.

https://hg.mozilla.org/webtools/tbpl/rev/e2bfd57e7e8f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Dammit, a qrefresh would have helped.
https://hg.mozilla.org/webtools/tbpl/rev/4c3d40ae1bfb

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

This job
  http://buildbot-master60.build.mozilla.org:8101/builders/b2g_try_emulator-kk_periodic/builds/0
has 
  The Nightly scheduler named 'b2g_try periodic' triggered this build.
It's also a 'try: -b do -p all', but scheduling seems to be incorrect.

post_upload.py fails to upload the log - Error, must supply who - which leads to nagios saying 'Command Queue is CRITICAL: 1 dead item'

Comment 13

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #11)
> https://hg.mozilla.org/webtools/tbpl/rev/4c3d40ae1bfb

In production.

Comment 14

[Chris AtLee [:catlee]]

Attachment: do per-push emulator-kk builds on try

Comment 15

[Justin Wood (:Callek)]

Comment on attachment 8389152 [details] [diff] [review]
do per-push emulator-kk builds on try

Review of attachment 8389152 [details] [diff] [review]:
-----------------------------------------------------------------

::: master-pip.txt
@@ -5,5 @@
>  amqplib==0.6.1
>  anyjson==0.3
>  argparse==1.1
>  carrot==0.10.7
> -distribute==0.6.14

I'm assuming this hunk was by accident, since this has no correlation to this bug afaict

::: mozilla/b2g_config.py
@@ +1212,5 @@
>  BRANCHES['try']['platforms']['emulator-jb-debug']['mozharness_config']['extra_args'] = ['--target', 'generic', '--config', 'b2g/releng-try.py', '--b2g-config-dir', 'emulator-jb', '--debug', '--gaia-languages-file', 'locales/languages_dev.json', '--gecko-languages-file', 'gecko/b2g/locales/all-locales']
>  BRANCHES['try']['platforms']['emulator-kk']['slaves'] = TRY_SLAVES['mock']
>  BRANCHES['try']['platforms']['emulator-kk']['mozharness_config']['extra_args'] = ['--target', 'generic', '--config', 'b2g/releng-try.py', '--b2g-config-dir', 'emulator-kk', '--gaia-languages-file', 'locales/languages_dev.json', '--gecko-languages-file', 'gecko/b2g/locales/all-locales']
> +BRANCHES['try']['platforms']['emulator-kk']['enable_dep'] = True
> +BRANCHES['try']['platforms']['emulator-kk']['enable_periodic'] = True

enable_periodic should be false, otherwise we get command queue errors... and imo periodic is indeed not valid on try.

Comment 16

[Chris AtLee [:catlee]]

Attachment: do per-push emulator-kk builds on try

doh, that's what I meant to do...doesn't actually matter since enable_dep overrides enable_periodic in bbcustom, but better to be clear here.