Closed Bug 979502 Opened 6 years ago Closed 6 years ago

[Contacts][import] - Update header design to accommodate larger back-button

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(1 obsolete file)

No description provided.
Attached file patch for Gaia/master (obsolete) —
Have in mind that this patch depends on bug 979473 and bug 979478
Comment on attachment 8385540 [details] [review]
patch for Gaia/master

Kaze, please review for the impact on Contacts import or reassign as appropriate. Thanks!
Attachment #8385540 - Flags: review?(kaze)
Comment on attachment 8385540 [details] [review]
patch for Gaia/master

The patch itself looks good but I can’t r+ it yet, since its two dependencies, bug 979473 and bug 979478, haven’t been r+’ed yet (and I’m not OK with these two patches at the moment).

Please r? Francisco when these two dependencies are ready to land in the shared style folder. Thanks!
Attachment #8385540 - Flags: review?(kaze)
PS: a pair of screenshots of the Import panel (before/after patch) would help, too. :-)
Component: Gaia → Gaia::Contacts
Summary: [import] - Update header design to accommodate larger back-button → [Contacts][import] - Update header design to accommodate larger back-button
Comment on attachment 8385540 [details] [review]
patch for Gaia/master

Francisco, can you review this when the two dependencies get r+’ed?
Attachment #8385540 - Flags: review?(francisco.jordano)
we don't need to change the markup anymore
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Attachment #8385540 - Attachment is obsolete: true
Attachment #8385540 - Flags: review?(francisco.jordano)
You need to log in before you can comment on or make changes to this bug.