Closed Bug 979516 Opened 6 years ago Closed 6 years ago

[homescreen] - Update header design to accommodate larger back-button

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(1 obsolete file)

No description provided.
Attached file patch for Gaia/master (obsolete) —
Have in mind that this patch depends on bug 979473 and bug 979478
Comment on attachment 8385553 [details] [review]
patch for Gaia/master

Gregor, please review or assign a reviewer for the implications on Homescreen. Thank you!
Attachment #8385553 - Flags: review?(anygregor)
Please add this to the UI that allows user to edit bookmarks [1], thanks a lot

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/elements/edit_dialog.html#L5
Status: NEW → ASSIGNED
Comment on attachment 8385553 [details] [review]
patch for Gaia/master

Cristian, can you put this in your queue?
Attachment #8385553 - Flags: review?(anygregor) → review?(crdlc)
Comment on attachment 8385553 [details] [review]
patch for Gaia/master

LGTM although I would like to add this change to the UI that allows user to edit bookmarks [1]

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/elements/edit_dialog.html#L5

Please, once addressed, request me again to put r+!

Thanks a lot, glad to land this patch because my parents told me several times that they had problems when they tried to close dialogs :)
Attachment #8385553 - Flags: review?(crdlc)
we don't need to change the markup anymore
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Attachment #8385553 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.