979516 - [homescreen] - Update header design to accommodate larger back-button

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Have in mind that this patch depends on bug 979473 and bug 979478

Comment 2

[Stephany Wilkes]

Comment on attachment 8385553 [details] [review]
patch for Gaia/master

Gregor, please review or assign a reviewer for the implications on Homescreen. Thank you!

Comment 3

[Cristian Rodriguez (:crdlc)]

Please add this to the UI that allows user to edit bookmarks [1], thanks a lot

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/elements/edit_dialog.html#L5

Comment 4

[Gregor Wagner [:gwagner]]

Comment on attachment 8385553 [details] [review]
patch for Gaia/master

Cristian, can you put this in your queue?

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8385553 [details] [review]
patch for Gaia/master

LGTM although I would like to add this change to the UI that allows user to edit bookmarks [1]

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/elements/edit_dialog.html#L5

Please, once addressed, request me again to put r+!

Thanks a lot, glad to land this patch because my parents told me several times that they had problems when they tried to close dialogs :)

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

we don't need to change the markup anymore