979787 - [GAIA][BUILD SYSTEM] new apps.list structure for multiple-devices

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

offline discussed,  new apps.list structure for multiple-devices.
build/config/${GAIA_DEVICE_TYPE}/apps-$(GAIA_APP_TARGET).list

Comment 1

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/17701

Hi Yuren,
   Please help to review this patch.
   If this patch is landed, we can use 'GAIA_DEVICE_TYPE=tablet make' to build tablet needed app.list.

   But we also need distribution_tablet in this phase, so I will file another bug for this issue.

   Thanks.

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8397751 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17701

that's good because more test cases were added, but it takes too much time to build different target.

I suggest removing test cases for demo, dogfood, and move verification of |GAIA_APP_TARGET=production make| to test case |PRODUCTION=1 make| to keep |make build-test-integration| not so slow.

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Ok, thanks.
needinfo myself.

Comment 4

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8397751 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17701

Hi Yuren,
   I've updated my patch with your comment, please review this patch again.

   Thanks.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8397751 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/17701

looks good r=yurenju, and please update MDN for GAIA_DEVICE_TYPE.

https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Build_System_Primer

Comment 6

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi Yuren,
   Thank for your review, I've updated MDN on following pages.
https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Build_System_Primer#GAIA_DEVICE_TYPE.3Dphone
https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking#Different_devices_of_build

   Please feel free to check and modify this document.


   I am waiting travis geen now.

Comment 7

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Landed in master
https://github.com/mpizza/gaia/commit/a2016db728d9e420649d2476fd82b4439ef6d42f

Travis green.
https://travis-ci.org/mozilla-b2g/gaia/builds/23013269