Closed
Bug 979787
Opened 11 years ago
Closed 11 years ago
[GAIA][BUILD SYSTEM] new apps.list structure for multiple-devices
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: GaryChen, Assigned: GaryChen)
References
Details
Attachments
(1 file)
offline discussed, new apps.list structure for multiple-devices. build/config/${GAIA_DEVICE_TYPE}/apps-$(GAIA_APP_TARGET).list
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gchen
Assignee | ||
Updated•11 years ago
|
Component: Gaia → Gaia::Build
Assignee | ||
Comment 1•11 years ago
|
||
Hi Yuren, Please help to review this patch. If this patch is landed, we can use 'GAIA_DEVICE_TYPE=tablet make' to build tablet needed app.list. But we also need distribution_tablet in this phase, so I will file another bug for this issue. Thanks.
Attachment #8397751 -
Flags: review?(yurenju.mozilla)
Comment 2•11 years ago
|
||
Comment on attachment 8397751 [details] [review] pull request: https://github.com/mozilla-b2g/gaia/pull/17701 that's good because more test cases were added, but it takes too much time to build different target. I suggest removing test cases for demo, dogfood, and move verification of |GAIA_APP_TARGET=production make| to test case |PRODUCTION=1 make| to keep |make build-test-integration| not so slow.
Attachment #8397751 -
Flags: review?(yurenju.mozilla)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8397751 [details] [review] pull request: https://github.com/mozilla-b2g/gaia/pull/17701 Hi Yuren, I've updated my patch with your comment, please review this patch again. Thanks.
Attachment #8397751 -
Flags: review?(yurenju.mozilla)
Flags: needinfo?(gchen)
Comment 5•11 years ago
|
||
Comment on attachment 8397751 [details] [review] pull request: https://github.com/mozilla-b2g/gaia/pull/17701 looks good r=yurenju, and please update MDN for GAIA_DEVICE_TYPE. https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Build_System_Primer
Attachment #8397751 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Hi Yuren, Thank for your review, I've updated MDN on following pages. https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Build_System_Primer#GAIA_DEVICE_TYPE.3Dphone https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking#Different_devices_of_build Please feel free to check and modify this document. I am waiting travis geen now.
Assignee | ||
Comment 7•11 years ago
|
||
Landed in master https://github.com/mpizza/gaia/commit/a2016db728d9e420649d2476fd82b4439ef6d42f Travis green. https://travis-ci.org/mozilla-b2g/gaia/builds/23013269
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•