979802 - [DSDS] After reboot device with SIM PIN and airplane mode enabled, device can still get MT call and SMS even unlock PIN and turn on Airplane mode again.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Enpei]

Attachment: time stamp: 16:37~38, 3/5

** If bug 979792 is by design **

After reboot device with SIM PIN and airplane mode enabled, device can still get MT call and SMS even unlock PIN and turn on Airplane mode again. This can be reproduced when there is only one SIM, or SIM 1 when both cards inserted.

* Build Number  
Fugu
Gaia      6781459a49642ca0eb7ec3e95667808d5d77b656
Gecko     d574219c44f75c9dfb007274e9de0479ef51020a
BuildID   20140305053055
Version   30.0a1

* Reproduce Steps
1. Insert SIM 1 only.
2. Enable SIM PIN and airplane mode.
3. Reboot device.
4. Unlock SIM PIN after reboot. 
5. Enable airplane mode again.
6. Once Airplane mode icon is on, MO/MT voice and SMS to DUT.

* Expected Result
Unable to MO/MT voice and SMS.

* Actual Result
MO failed while device can still receive voice and SMS. Need to turn off/on airplane mode again to make it normal.

* Occurrence rate
100%

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug_979802_fugu_radio_log.txt

Attach the log with radio log enabled.

I can repro this issue as well,

STR:
1). Insert one sim card only.
2). Enable airplane mode and sim PIN.
3). Reboot device.
4). After reboot, device is in airplane mode and pin unlock.
5). Unlock pin.
6). Device leaves airplane mode automatically.
7). Enable airplane mode again.
8). But device still can receive call and SMS.

Note:
"ro.moz.ril.radio_off_wo_card" is set to true in my device.

Comment 2

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8387555 [details]
> Bug_979802_fugu_radio_log.txt
> 
> Attach the log with radio log enabled.
> 
> I can repro this issue as well,
> 
> STR:
> 1). Insert one sim card only.
> 2). Enable airplane mode and sim PIN.
> 3). Reboot device.
> 4). After reboot, device is in airplane mode and pin unlock.
> 5). Unlock pin.
> 6). Device leaves airplane mode automatically.

Radio power becomes to "enabled" automatically after unlocked pin.

=====
03-07 20:51:13.710   106   106 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","pin":"0000","requestId":"id{7dfa6988-480b-4ee1-ba3c-9b4b989921f2}","rilMessageToken":11,"rilMessageType":"iccUnlockCardLock","rilRequestType":2,"rilRequestError":0,"success":true,"retryCount":-1}

03-07 20:51:13.980   106   106 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"radiostatechange","radioState":"enabled"}
===

> 7). Enable airplane mode again.
> 8). But device still can receive call and SMS.

Modem reports radio off, but the voice is still registered.

====
03-07 20:51:36.066   106   106 I Gecko   : -*- RadioInterface[0]: setRadioEnabled: {"requestId":"id{e397259b-9431-4c04-aafb-88ecff5fbd92}","enabled":false}

03-07 20:51:36.186   106   106 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"rilMessageType":"radiostatechange","radioState":"disabled"}

03-07 20:51:41.256   361   361 I Gecko   : -*- RILContentHelper: Received message 'RIL:VoiceInfoChanged': {"clientId":0,"data":{"connected":true,"emergencyCallsOnly":false,"roaming":false,"network":{"longName":"Chunghwa","shortName":"CHT","mcc":"466","mnc":"92"},"cell":{"gsmLocationAreaCode":10235,"gsmCellId":19233895},"type":"umts","signalStrength":-51,"relSignalStrength":100,"state":"registered"}}
====

> 
> Note:
> "ro.moz.ril.radio_off_wo_card" is set to true in my device.

It seems modem's issue.

Hi Sam, could you help to check above two symptom in your side?

Thank you

Comment 3

[sam.hua]

Hi,
Our RILC won't add any parameters to UNSOLICITED_RESPONSE_RADIO_STATE_CHANGED

     RIL_onUnsolicitedResponse (RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED,
                NULL, 0);

any parameters should be added to RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED ?

Comment 4

[Edgar Chen [:edgar]]

(In reply to sam.hua from comment #3)
> Hi,
> Our RILC won't add any parameters to UNSOLICITED_RESPONSE_RADIO_STATE_CHANGED
> 
>      RIL_onUnsolicitedResponse (RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED,
>                 NULL, 0);
> 
> any parameters should be added to RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED ?

Hi Sam,

Hmm, ril.h doesn't have enough information about this [1]. But checking the AOSP implementation, RIL_UNSOL_RESPONSE_RADIO_STATE_CHANGED will come with current radio state [2].

And from the log, it seems rild has provided the same information, doesn't it?
Please let me know if I misunderstand any thing, thank you.

====
03-07 20:51:36.116   100   286 D RILC    : [w] [UNSL]< UNSOL_RESPONSE_RADIO_STATE_CHANGED  {RADIO_OFF}

03-07 20:51:36.136   106   223 I Gecko   : RIL Worker[0]: New incoming parcel of size 12
03-07 20:51:36.136   106   223 I Gecko   : RIL Worker[0]: Parcel (size 12): 1,0,0,0,232,3,0,0,0,0,0,0
03-07 20:51:36.136   106   223 I Gecko   : RIL Worker[0]: We have at least one complete parcel.
03-07 20:51:36.136   106   223 I Gecko   : RIL Worker[0]: Unsolicited response for request type 1000
03-07 20:51:36.136   106   223 I Gecko   : RIL Worker[0]: Handling parcel as UNSOLICITED_RESPONSE_RADIO_STATE_CHANGED
03-07 20:51:36.136   106   223 I Gecko   : RIL Worker[0]: Radio state changed from 'enabled' to 'disabled'
=====

[1] https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/include/telephony/ril.h#L3338-L3348
[2] http://androidxref.com/source/xref/frameworks/opt/telephony/src/java/com/android/internal/telephony/RIL.java#2523

Comment 5

[sam.hua]

yes,u are right,
ril.cpp will append the state to UNSOL_RESPONSE_RADIO_STATE_CHANGED.

could u test it in Tarako,it looks like that Tarako has fixed this issue. it convert the radio_state of RILC to AOSP

Comment 6

[Edgar Chen [:edgar]]

It seems a partner's bug, so change component to Vendcom.

Comment 7

[Edgar Chen [:edgar]]

(In reply to sam.hua from comment #5)
> yes,u are right,
> ril.cpp will append the state to UNSOL_RESPONSE_RADIO_STATE_CHANGED.
> 
> could u test it in Tarako,it looks like that Tarako has fixed this issue. it
> convert the radio_state of RILC to AOSP

Hmm, in face, Tarako has different behavior with Fugu.
Tarako doesn't allow to unlock pin if radio is off.

Comment 8

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #7)
> (In reply to sam.hua from comment #5)
> > yes,u are right,
> > ril.cpp will append the state to UNSOL_RESPONSE_RADIO_STATE_CHANGED.
> > 
> > could u test it in Tarako,it looks like that Tarako has fixed this issue. it
> > convert the radio_state of RILC to AOSP
> 
> Hmm, in face, Tarako has different behavior with Fugu.
       ^^^^^^^ typo: in fact
> Tarako doesn't allow to unlock pin if radio is off.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think this might be a cert blocker.  Airplane mode should not allow radio at all...

Comment 10

[Keven Kuo [:kkuo]]

(In reply to Edgar Chen [:edgar][:echen] from comment #6)
> It seems a partner's bug, so change component to Vendcom.

Hi! James,

Could you check this from your side? Thanks

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

it looks like sam's looking at this, assign to sam for now. please reassign if this is incorrect. thanks

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

hi Sam, wonder if you have some updates? thanks

Comment 13

[sam.hua]

Hi jcheng,

i will fix it today

Comment 14

[sam.hua]

Attachment: libreference-ril_sp.so

please check the new two libs.

Comment 15

[sam.hua]

Attachment: libril_sp.so

two libs updated for this bug

Comment 16

[thomas tsai]

Hi Sam: I found two commits 9b3e1cfe509c9fa78445bde3618e4ccd36743765, 20c72af4988b16922453a3f93fe7f6234c9a593d. Are these two the updated?

Comment 17

[sam.hua]

Hi Thomas.
Yes,this problem is happened in Fugu,not Tarako.

20c72af4988b16922453a3f93fe7f6234c9a593d:
update libs for  After adding a number to FDN and entering the wrong SIM2 pin the "The PIN2 code is incorrect." 

9b3e1cfe509c9fa78445bde3618e4ccd36743765
Bug #255090 modem should return error if setting preferred network type fails

Comment 18

[James Zhang (Spreadtrum)]

(In reply to sam.hua from comment #17)
> Hi Thomas.
> Yes,this problem is happened in Fugu,not Tarako.
> 
> 20c72af4988b16922453a3f93fe7f6234c9a593d:
> update libs for  After adding a number to FDN and entering the wrong SIM2
> pin the "The PIN2 code is incorrect." 
> 
> 9b3e1cfe509c9fa78445bde3618e4ccd36743765
> Bug #255090 modem should return error if setting preferred network type fails

Please close it if tarako don't have this issue.

Comment 19

[Joe Cheng [:jcheng] (please needinfo)]

can this bug be closed now? thanks

Comment 20

[sam.hua]

yes