979905 - Make VectorImage use a Moz2D backed gfxContext

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

We should make VectorImage use a Moz2D backed gfxContext.

Working out the issues that we'll encounter trying to do this will smooth the path for converting imgIContainer::GetFrame to return a Moz2D SourceSurface instead of a Thebes gfxASurface (bug 950372).

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Waiting on Try to see exactly what fails as a result of this.

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8386144 [details] [diff] [review]
patch

Surprisingly this seems to pass Try without causing any annoying slightly-different-pixel-value failures. \o/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8386144 [details] [diff] [review]
patch

Review of attachment 8386144 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/src/VectorImage.cpp
@@ +680,5 @@
>  
> +  RefPtr<DataSourceSurface> dataSurface =
> +    Factory::CreateDataSourceSurface(IntSize(imageIntSize.width,
> +                                             imageIntSize.height),
> +                                     SurfaceFormat::B8G8R8A8);

Leave the code to create a gfxImageSurface here, and use CreateDrawTargetForData around that data instead.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 6

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6c037057c02

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6c037057c02