Make VectorImage use a Moz2D backed gfxContext

RESOLVED FIXED in mozilla30

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks 2 bugs)

29 Branch
mozilla30
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

We should make VectorImage use a Moz2D backed gfxContext.

Working out the issues that we'll encounter trying to do this will smooth the path for converting imgIContainer::GetFrame to return a Moz2D SourceSurface instead of a Thebes gfxASurface (bug 950372).
Posted patch patch (obsolete) — Splinter Review
Waiting on Try to see exactly what fails as a result of this.
Comment on attachment 8386144 [details] [diff] [review]
patch

Surprisingly this seems to pass Try without causing any annoying slightly-different-pixel-value failures. \o/
Attachment #8386144 - Attachment description: WIP → patch
Attachment #8386144 - Flags: review?(matt.woodrow)
Comment on attachment 8386144 [details] [diff] [review]
patch

Review of attachment 8386144 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/src/VectorImage.cpp
@@ +680,5 @@
>  
> +  RefPtr<DataSourceSurface> dataSurface =
> +    Factory::CreateDataSourceSurface(IntSize(imageIntSize.width,
> +                                             imageIntSize.height),
> +                                     SurfaceFormat::B8G8R8A8);

Leave the code to create a gfxImageSurface here, and use CreateDrawTargetForData around that data instead.
Posted patch patch (obsolete) — Splinter Review
Attachment #8386144 - Attachment is obsolete: true
Attachment #8386144 - Flags: review?(matt.woodrow)
Attachment #8386445 - Flags: review?(matt.woodrow)
Posted patch patchSplinter Review
Attachment #8386445 - Attachment is obsolete: true
Attachment #8386445 - Flags: review?(matt.woodrow)
Attachment #8386447 - Flags: review?(matt.woodrow)
Attachment #8386447 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/c6c037057c02
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.