980402 - Remove navigator.mozMobileConnection uses from the homescreen app / everything.me

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Gabriele Svelto [:gsvelto]]

The homescreen app still uses navigator.mozMobileConnection via everything.me:

https://github.com/mozilla-b2g/gaia/blob/0742d628484fcb88d5b9d91942581daaf23fefb9/apps/homescreen/everything.me/js/helpers/Utils.js#L1011

That uses should be removed and the relevant code must be made to rely only on navigator.mozMobileConnections.

Comment 1

[kumar rishav (:rishav_)]

Attachment: Bug 980402 - Remove navigator.mozMobileConnection uses from the homescreen app / everything.me

Hi gabriele
Can you have a look on attached PR?.
Thanks

Comment 2

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8407066 [details] [review]
Bug 980402 - Remove navigator.mozMobileConnection uses from the homescreen app / everything.me

LGTM.

Comment 3

[kumar rishav (:rishav_)]

Hi gabriele
I did the suggested change.Can you assign this bug to me?
Also Can you Please set the review flag to related peer?
Thanks

Comment 4

[Gabriele Svelto [:gsvelto]]

(In reply to kumar rishav from comment #3)
> I did the suggested change.Can you assign this bug to me?

Done.

> Also Can you Please set the review flag to related peer?

You have to set the flag yourself, you can find the Homescreen / Everything.me peers on this page:

https://wiki.mozilla.org/Modules/FirefoxOS#Homescreen

Comment 5

[kumar rishav (:rishav_)]

Comment on attachment 8407066 [details] [review]
Bug 980402 - Remove navigator.mozMobileConnection uses from the homescreen app / everything.me

Hi [e-mail]
Can you have a look on PR?
Thanks

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8407066 [details] [review]
Bug 980402 - Remove navigator.mozMobileConnection uses from the homescreen app / everything.me

Good job!, Thanks a lot

Comment 7

[Gabriele Svelto [:gsvelto]]

Thanks to both, merged to gaia/master a87266f3ddb4f43ac95924faedc0fa445cb3dffd

https://github.com/mozilla-b2g/gaia/commit/a87266f3ddb4f43ac95924faedc0fa445cb3dffd