980387 - [meta] Retire mozMobileConnection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Gabriele Svelto [:gsvelto]]

As per bug 958733 comment 25, navigator.mozMobileConnection is history, we should retire all its uses from Gaia and ensure that unit-tests do not use it anymore too relying on the navigator.mozMobileConnections mock instead.

Comment 1

[Gabriele Svelto [:gsvelto]]

I've gathered all remaining uses in apps in dependent bugs, there's still a few places that need to be addressed too:

https://github.com/mozilla-b2g/gaia/blob/56fc721c23e37ead9da0a42154098696ad1d2959/test_apps/test-otasp/js/otasp.js#L10
https://github.com/mozilla-b2g/gaia/blob/56fc721c23e37ead9da0a42154098696ad1d2959/shared/js/tz_select.js#L39
https://github.com/mozilla-b2g/gaia/blob/56fc721c23e37ead9da0a42154098696ad1d2959/tests/atoms/gaia_data_layer.js#L357
https://github.com/mozilla-b2g/gaia/blob/56fc721c23e37ead9da0a42154098696ad1d2959/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L245

Also shared/test/unit/mocks/mock_navigator_moz_mobile_connection.js should be removed once we remove all its uses.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: [PULL REQUEST] Remove all remaining uses of navigator.mozMobileConnection

This patch removes all the remaining uses of navigator.mozMobileConnection. Tim, tThe changes are in various places but I don't think it's worth chasing multiple reviews for the multiple bits so if you don't mind to r+ this we can get rid of this legacy.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8554247 [details] [review]
[PULL REQUEST] Remove all remaining uses of navigator.mozMobileConnection

I think you should also remove the comment above.

Comment 4

[Gabriele Svelto [:gsvelto]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #3)
> I think you should also remove the comment above.

Good point, I had missed them. I'll update the PR.

Comment 5

[Gabriele Svelto [:gsvelto]]

The change in tz_select.js is making integration tests break. I imagine this must be due to some mock implementing navigator.mozMobileConnection but not navigator.mozMobileConnections. That will require a little more investigation before I'm able to land this.

Comment 6

[Gabriele Svelto [:gsvelto]]

I had to do a minuscule adjustment to tz_select.js, this is the try run: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=b1ca2384798d

Merged to gaia/master 1a51fdbe47b8a92a1df1d02b6a86cbac280d02e9

https://github.com/mozilla-b2g/gaia/commit/1a51fdbe47b8a92a1df1d02b6a86cbac280d02e9