980415 - Fix multiple points in the codebase where we fail to call DataSourceSurface::Unmap()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

Care needs to be taken when using DataSourceSurface::Map() because we need to have a corresponding DataSourceSurface::Unmap() call to unlock the DataSourceSurface. Multiple points in the codebase have failed to ensure they always call Unmap(), usually because the function calling Map() has a return point that fails to call Unmap() (sometimes the return point is hidden by an NS_ENSURE_* macro). Anyway, we should fix the existing points in the code.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch for most points

This covers most callers. There's at least one other broken caller in widget/windows/nsDragService.cpp but that seems more widely broken so I'll deal with that in a separate bug.

Comment 2

[Jonathan Watt [:jwatt]]

This patch also fixes callers that test for success by checking map.mData - that's wrong since map.mData can be untouched (uninitialized) if Map() returned false.

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8f0eb5251eb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8f0eb5251eb