980582 - [e10s] Linux + Hardware Acceleration + WebGL Error spew: "isCrossProcess, but not MOZ_WIDGET_GONK! Someone needs to write some code!"

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[John Schoenick [:johns]]

It looks like someone needs to write some code:
http://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/CanvasClient.cpp#163

Comment 1

[Kelsey Gilbert [:jgilbert]]

It's true! This is sort of Layers, as opposed to actual WebGL, though.

Comment 2

[Tom S [:evilpie]]

Attachment: fix

This is probably not what we want to ship with, but at least it works.

Comment 3

[Tom S [:evilpie]]

Comment on attachment 8395797 [details] [diff] [review]
fix

Okay I going to look into this some more.

Comment 6

[Tom S [:evilpie]]

Attachment: other

I think this is good enough for a crash fix.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8400766 [details] [diff] [review]
other

Review of attachment 8400766 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/CanvasClient.cpp
@@ +37,5 @@
>                                   TextureFlags aFlags)
>  {
> +#ifndef MOZ_WIDGET_GONK
> +  if (XRE_GetProcessType() != GeckoProcessType_Default) {
> +    // Fixme: Most platforms still need an optimized way to share GL cross process.

NS_Warning or something like that? Also, I thought this might regress OS X where we already use IOSurfaces to share surfaces, but it looks like WebGL is still broken.

Comment 8

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b8036ab4f81

Comment 9

[Marc Auslander]

Fixes bug: https://bugzilla.mozilla.org/show_bug.cgi?id=991164

Thanks

Comment 10

[Tom S [:evilpie]]

(In reply to Marc Auslander from comment #9)
> Fixes bug: https://bugzilla.mozilla.org/show_bug.cgi?id=991164
> 
> Thanks

I am actually kind of curious on why that is. Just enabling OMTC would still have everything in the same process, so the code shouldn't be hit at all.

Comment 11

[Marc Auslander]

Since I may have done a previous experiment poorly - I have enabled both 

layers.offmainthreadcomposition.enabled and
layers.offmainthreadcomposition.testing.enabled

although I believe only the former was needed to trigger bug 91164.

In any case, it's not failing for me right now.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b8036ab4f81

Comment 13

[Marc Auslander]

This fixes bug 991164.  Thanks.