980606 - new tab search input affiliate codes

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

Before we land the search input (bug 962490) on the new tab page we need new affiliate codes from our default search partners.  This may take a bit of time to complete and the search input will need to block landing on these codes arriving.

Joanne (cc'd) will deliver the codes into this bug, when she gives the OK in this bug we can land the search input for bug 962490.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Seems unlikely that we need to block landing on this. Reasonable to block shipping to beta. Do you disagree?

Comment 2

[Joanne Nagel]

Yes, I disagree.  As this is a public bug, please reach out in email if you want further details.  Thanks, Joanne

Comment 3

[:Gavin Sharp [email: [e-mail]]]

There shouldn't be any reason why you can't explain the objection without resorting to specifics in a public bug, but I sent you an email.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Partners have been informed, we don't have codes yet but will receive them soon and can go ahead with landing the change in Nightly.

Comment 5

[Mike Connor [:mconnor]]

The form code for Bing is MOZTSB.  Is there a "purpose" argument defined yet?  Are we going to get something from Google as well?

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to Mike Connor [:mconnor] from comment #5)
> The form code for Bing is MOZTSB.  Is there a "purpose" argument defined
> yet?  Are we going to get something from Google as well?

I think we need gavin to answer that

Comment 7

[:Gavin Sharp [email: [e-mail]]]

The patch in bug 962490 uses a "newtab" purpose.

This bug just needs to provide the parameters, we can handle the implementation details in bug 962490.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Drawing from bug 962490 comment 80 it looks like current status is this:

- no code needed -
Amazon
eBay

- new code landed -
Bing code = MOZTSB, pc = MOZI

- waiting on new codes -

Google Channel ID : need before we move into GA
Yahoo

Joanne, any status on how Yahoo is progressing?  or update Google?

Comment 9

[Drew Willcoxon :adw]

(In reply to Bryan Clark (Firefox Search PM) [:clarkbw] from comment #8)
> Google Channel ID : need before we move into GA

Thanks for the summary, Bryan, but what do you mean by GA?  Do we need to prevent bug 962490 from reaching Beta and Release until we have the Google code?

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to Drew Willcoxon :adw from comment #9)
> (In reply to Bryan Clark (Firefox Search PM) [:clarkbw] from comment #8)
> > Google Channel ID : need before we move into GA
> 
> Thanks for the summary, Bryan, but what do you mean by GA?  Do we need to
> prevent bug 962490 from reaching Beta and Release until we have the Google
> code?

Sorry, that's (General Avail) release and yes, I believe we do need to prevent it from going to release without the Google code.

Comment 11

[Joanne Nagel]

Google would like the name of the new channel to be "nts" for "new tab" when we move to GA.  Thanks.

Comment 12

[Drew Willcoxon :adw]

So does that mean once we add that channel code to the source code, we don't need to hold bug 962490 from Beta and Release on account of Google?

Do we need to hold it for the outstanding Yahoo code or for any other reason?

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to Drew Willcoxon :adw from comment #12)
> So does that mean once we add that channel code to the source code, we don't
> need to hold bug 962490 from Beta and Release on account of Google?

Yes, exactly.

> Do we need to hold it for the outstanding Yahoo code or for any other reason?

I'd like Joanne to confirm but I believe we're good now and can add the Yahoo or other codes as we get them.  I think uplifting those other codes as we get them would be ideal.

Comment 14

[Joanne Nagel]

At this point I would recommend using the standard Yahoo code for the new tab access point and if they finally generate a new one, we can substitute it as necessary.  

So to summarize, except for the Google code to be included only in GA, we should include all logo's and codes regardless of channel for Amazon, Bing, eBay and Yahoo.

Comment 15

[Drew Willcoxon :adw]

(In reply to Joanne Nagel from comment #11)
> Google would like the name of the new channel to be "nts" for "new tab" when
> we move to GA.  Thanks.

Hopefully last question: "when we move to GA" -- is it OK if that channel code is used in Nightly, Aurora, and Beta?  I presume so but want to make sure.

Comment 16

[Mike Connor [:mconnor]]

On Yahoo: we don't do per-SAP tracking codes at present, so I'd expect the same thing going forward.

On Google, it's my understanding that they don't really track anything not on GA, and all other SAPs use the same channel= code regardless of our release channel/branding, so I'd follow that model here.

Comment 17

[Joanne Nagel]

Just to confirm - Mike's comments are accurate.

Comment 18

[Bryan Clark (DevTools PM) [:clarkbw]]

Summarizing again.

We're all set to land the Google & Yahoo codes, though we haven't gotten an official return from Yahoo.

Here's the list:

- n/a -
Amazon
eBay

- done -
Bing code = MOZTSB, pc = MOZI

- need to land -
Google: use the "nts" channel id
Yahoo: use the standard Yahoo code, if they generate a new one we update it later

Comment 19

[Drew Willcoxon :adw]

(In reply to Bryan Clark (Firefox Search PM) [:clarkbw] from comment #18)
> - need to land -
> Google: use the "nts" channel id
> Yahoo: use the standard Yahoo code, if they generate a new one we update it
> later

I filed bug 1009318 for landing the Google code.  Given the above, we don't need to land a new purpose code for Yahoo.  So once bug 1009318 lands we can close this bug, filing a new bug for Yahoo if/when necessary.

Comment 20

[Drew Willcoxon :adw]

Bug 1009318 landed, so I'm resolving this bug.