980746 - UITour: Many browser-chrome tests leak 1 docshell when run alone

Status: RESOLVED DUPLICATE of bug 992611

(Firefox :: General, defect)

Description

[Matthew N. [:MattN]]

e.g. browser/modules/test/browser_UITour_annotation_size_attributes.js | leaked 1 docShell(s) until shutdown

It doesn't happen in all of them but does in most.

Comment 3

[Matthew N. [:MattN]]

At least one of the causes is speculative connections from the search bar (since we have a search target) that gets tested. See also bug 964369.

This is reproducible on OS X 10.9 too.

Comment 4

[Matthew N. [:MattN]]

Attachment: v.1 Disable speculative connections for the search bar

Patrick, let me know if you prefer my suggestion in bug 964369 comment 3 to disable speculative connections by default in the test suites?

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8402264 [details] [diff] [review]
v.1 Disable speculative connections for the search bar

Review of attachment 8402264 [details] [diff] [review]:
-----------------------------------------------------------------

r+ on the code, but it's on the condition that this patch is only used if for some reason we can't use bug 992611 - because that's a far better solution, IMO.

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Also, nice catch :)

Comment 7

[Patrick McManus [:mcmanus]]

Comment on attachment 8402264 [details] [diff] [review]
v.1 Disable speculative connections for the search bar

Review of attachment 8402264 [details] [diff] [review]:
-----------------------------------------------------------------

agree that 992611 is the way to go