Closed
Bug 992611
Opened 11 years ago
Closed 11 years ago
mochitest-bc chunk2 perma-leak on all platforms on Cedar - (DOMStorageManager, EventTokenBucket, Mutex, ReentrantMonitor, Service, ...)
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: RyanVM, Assigned: MattN)
References
Details
(Keywords: memory-leak)
Attachments
(1 file)
1.41 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
We're seeing this perma-leak across all platforms when we run mochitest-bc in chunks and devtools split into their own testsuite on Cedar. This is blocking our ability to enable these changes in production.
Andrew, any chance you could lend a hand investigating? Logs are available in any bc2 run shown here:
https://tbpl.mozilla.org/?tree=Cedar&jobname=mochitest.*chrome&rev=860811be1a5d
Reporter | ||
Comment 1•11 years ago
|
||
FWIW, it started on this push:
https://hg.mozilla.org/projects/cedar/rev/50dab12cadf1
Reporter | ||
Comment 2•11 years ago
|
||
Which basically agrees with "don't run devtools tests with the rest of mochitest-bc and get leaks"
Comment 3•11 years ago
|
||
Hmm. Looks like networking stuff.
Reporter | ||
Comment 4•11 years ago
|
||
Oh, this is probably a dupe of bug 964369, except now it's a perma-leak.
Assignee | ||
Comment 5•11 years ago
|
||
Can you test the patch in bug 964369 and see if it helps? Thanks
Flags: needinfo?(ryanvm)
Comment 6•11 years ago
|
||
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 7•11 years ago
|
||
I found an xpcshell test for this API but prefs_general.js isn't used on xpcshell so I didn't need to modify it.
Try push: https://tbpl.mozilla.org/?tree=Try&rev=d390d6041643
Comment 9•11 years ago
|
||
pushed to cedar, here is a view of bc2 (the leaking test):
https://tbpl.mozilla.org/?tree=Cedar&jobname=cedar%20debug%20test%20mochitest-browser-chrome-2&rev=16a531cb05bd
Flags: needinfo?(ryanvm)
Comment 10•11 years ago
|
||
looks like the leak is gone:
https://tbpl.mozilla.org/?tree=Cedar&rev=16a531cb05bd
nice stuff.
Comment 11•11 years ago
|
||
Comment on attachment 8402279 [details] [diff] [review]
v.1 Set network.http.speculative-parallel-limit to 0 in non-xpcshell tests
Review of attachment 8402279 [details] [diff] [review]:
-----------------------------------------------------------------
I'm fine with this. The test suite is not supposed to be making external connections and it certainly is doing so in the current state of things.
As comment 7 says, there is at least some coverage for Speculative Connections in xpcshell that is unaffected by at least this change.
Attachment #8402279 -
Flags: review?(mcmanus) → review+
Comment 12•11 years ago
|
||
should I consider adding this to talos?
Reporter | ||
Comment 13•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 14•11 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #12)
> should I consider adding this to talos?
It would probably be good to do since I believe TART can run with the New Tab Page showing (which also does speculative connections). If the mouse cursor happens to be over a tile, it could make a connection.
Comment 15•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla31
Reporter | ||
Comment 16•11 years ago
|
||
status-firefox30:
--- → fixed
status-firefox31:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•