980817 - [v1.3][Cost Control] Resetting wi-fi usage from Cost Control app does not always reset to 0 B

Status: RESOLVED DUPLICATE of bug 838928

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Robert Chira [:RobertC]]

This issue is reproduced intermittently on local device with manual and automated testing.

Steps to reproduce:

1. Connect to wi-fi.
2. Open cost control and configure it to monitor wi-fi usage.
3. Open browser and visit a site (i.e., http://mozqa.com/data/firefox/layout/mozilla.html).
4. Disconnect wi-fi.
5. Open cost control and observe values. Wi-fi usage will be as expected.
6. Go to Cost Control Settings and reset wi-fi usage. Observe new value for wi-fi usage.

Expected result: View 0 B in step 6.
Actual result: View a small amount in step 6 (e.g., in the test it was 10.00 B)

Tested on Hamachi
Gaia      e8bf7326ce5ed63bc8ef8b2cff1eba094887b9bf
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/efc5a13f2ba6
BuildID   20140306164002
Version   28.0
ro.build.version.incremental=eng.tclxa.20131223.163538
ro.build.date=Mon Dec 23 16:36:04 CST 2013

I also started an adhoc run, where 25% of the tests failed for this reason.
http://qa-selenium.mv.mozilla.com:8080/job/b2g.hamachi.mozilla-b2g28_v1_3.adhoc/25/

Comment 1

[Noemí Freire (:noemi)]

Hi,

This issue could be related to Wi-Fi appearing as OFF but not being OFF, please see bug 838928. Could you please follow the steps described in https://bugzilla.mozilla.org/show_bug.cgi?id=838023#c4 to be sure Wi-Fi is OFF and discard bug 838928 as the root cause of the issue you are reporting here?. Thanks!

Comment 2

[Robert Chira [:RobertC]]

I followed the steps described in the comment and found that the Wi-fi is OFF after disabling it from setting. I don't think bug 838928 is the cause of this issue.

Comment 3

[Jason Smith [:jsmith]]

Can someone else confirm this as well on 1.3?

Comment 4

[sarsenyev]

Yes, I am confirming the issue reproduces on 1.3
The Wi-Fi usage is not always reseted to "0.00"B

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140306004002
Gaia: 8aed4fafbaeb86d6884d31ce7d3cbeb87bcbf837
Gecko: 3d2d84d52141
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 5

[Jason Smith [:jsmith]]

Noemi - Can you find an assignee for this?

Comment 6

[Albert [:albert]]

I can work on it.

Comment 7

[sarsenyev]

There is no regression window for 1.3, the issue reproduces on 1.2 and 1.1 builds
Sometimes WiFi cost control doesn't reset to 0.00B

1.1 Environmental Variables:
Device: Buri 1.1 MOZ
BuildID: 20140306041201
Gaia: 44a2ddf63373f8e95c784faf4ed4d60081699c61
Gecko: 1421a6b7fc51
Version: 18.0
Firmware Version: v1.2-device.cfg

Comment 8

[Jason Smith [:jsmith]]

(In reply to sarsenyev from comment #7)
> There is no regression window for 1.3, the issue reproduces on 1.2 and 1.1
> builds
> Sometimes WiFi cost control doesn't reset to 0.00B
> 
> 1.1 Environmental Variables:
> Device: Buri 1.1 MOZ
> BuildID: 20140306041201
> Gaia: 44a2ddf63373f8e95c784faf4ed4d60081699c61
> Gecko: 1421a6b7fc51
> Version: 18.0
> Firmware Version: v1.2-device.cfg

That's not the right bug you are testing here - please reanalyze again.

Comment 9

[sarsenyev]

After I followed steps in bug 838928, verifying WiFi is off with "adb shell netcfg", I no longer can reproduce this issue, I tried multiple times but WiFi is always resets to 0.00B

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140312004001
Gaia: df157ce3a3f841850a1cce8f057f8e7f547fb9f8
Gecko: c629684b0eae
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 10

[Jason Smith [:jsmith]]

(In reply to sarsenyev from comment #9)
> After I followed steps in bug 838928, verifying WiFi is off with "adb shell
> netcfg", I no longer can reproduce this issue, I tried multiple times but
> WiFi is always resets to 0.00B
> 
> 1.3 Environmental Variables:
> Device: Buri 1.3 MOZ
> BuildID: 20140312004001
> Gaia: df157ce3a3f841850a1cce8f057f8e7f547fb9f8
> Gecko: c629684b0eae
> Version: 28.0
> Firmware Version: v1.2-device.cfg

That's not the bug that's being analyzed here...

Comment 11

[sarsenyev]

Regression window was found in bug 965305 Comment #4 from Peter Bylenga 

"This issue has an average reproducibility rate of 20% or 1/5 attempts.
Regression window is 11-26-2013 to 11-27-2013.  On 11-26-2013 is the last build where we see bug 942060 which blocks reproducing the current issue.  On builds before the regression window found in 942060, I was not able to reproduce the issue.

Last build issue did not reproduce:
v1.3 Environmental Variables:
Device: Buri v1.3 MOZ
BuildID: 20131126052050
Gaia: 4ad796b196d468bdb231beba4392acbc90a74e96
Gecko: 99479edbee2a
Version: 28.0a1
Firmware Version: v1.2-device.cfg

First build issue reproduces:
v1.3 Environmental Variables:
Device: Buri v1.3 MOZ
BuildID: 20131127040203
Gaia: d4b9a3d271f0451b4d903a03c2b931b8cc092041
Gecko: 6ecf0c4dfcbe
Version: 28.0a1
Firmware Version: v1.2-device.cfg"

Comment 12

[Jason Smith [:jsmith]]

That's not what I'm looking for here. I'm looking for the regression window on this bug specifically. Not the window of another bug with similar causes.

Comment 13

[Sarah Parsons]

Bug 838928 is the root cause of this issue. Disabling wifi via the settings will not completely turn OFF wifi, If the user pulls down the notification bar, wifi is still enabled. That's why the cost control app wind reset to 0B. 

If the user disables wifi completely via https://bugzilla.mozilla.org/show_bug.cgi?id=838023#c4 the issue does not reproduce.

Comment 14

[Jason Smith [:jsmith]]

(In reply to Sarah Parsons from comment #13)
> Bug 838928 is the root cause of this issue. Disabling wifi via the settings
> will not completely turn OFF wifi, If the user pulls down the notification
> bar, wifi is still enabled. That's why the cost control app wind reset to
> 0B. 
> 
> If the user disables wifi completely via
> https://bugzilla.mozilla.org/show_bug.cgi?id=838023#c4 the issue does not
> reproduce.

I don't think so. The bug as filed here is describing an intermittent failure to reset usage down to zero post an immediate operation to reset it, not actually doing something else in process to trigger wifi usage without a network connection. comment 2 already confirmed that this is a different problem, as the reporter indicated that they confirmed the wifi was set to OFF.

Reflagging again. We're missing something important here that's not being tested correctly here. A first thing we need to do is verify if this reproduces on a 2/19 1.3 build or not. If it does reproduce, then bug 965305 didn't fix the problem here.

Comment 15

[Jason Smith [:jsmith]]

Robert - Can you double check if you can reproduce this on the latest build & re-verify that the Wifi was definitely set to OFF here? There's apparently a lot of confusion with your comment & the below testing.

Comment 16

[Jason Smith [:jsmith]]

I'm going to wait Robert to come back here before re-flag any QA keywords.

Comment 17

[Robert Chira [:RobertC]]

I retested this on hamachi with the following build:
Gaia      e61dc0019d9d6135d88ba15153c37f73a952567e
Gecko     https://hg.mozilla.org/mozilla-central/rev/a10d0ba50f64
BuildID   20140312160210
Version   30.0a1
ro.build.version.incremental=eng.tclxa.20131223.163538
ro.build.date=Mon Dec 23 16:36:04 CST 2013

This issue is hard to rerpoduce manually, in our automated tests disabling the wifi is not done by going to settings. It is done with the help of the "disableWifi()" method found at https://github.com/mozilla-b2g/gaia/blob/master/tests/atoms/gaia_data_layer.js#L241

In the test between disabling the wifi and resetting the data usage I ran the "netcfg" shell command which always returned "wlan0    DOWN". When I observed the test failing with this issue I stopped it and ran "netcfg", but got the same result. Also, when looking in the notification bar I see the wifi set to OFF and the data usage is 0.00B.

Note: When this test fails, after resetting cost control the data usage is always 10.00 B.

Sarah - Can you provide some steps as to how you reproduced the issue and noticed that the wifi is still on?

Comment 18

[Albert [:albert]]

Attachment: Log

I prepared some scripts trying to figure out what can be happening here.

The attached log file shows three different kinds of traces:

1) Traces from a script monitoring the /proc/net/dev, it scan the file waiting for changes in wlan received bytes and print them when those are increased.

2) From logcat: wlan0: CTRL-EVENT-TERMINATING. This event is triggered when there is a click to switch off wifi

3) Traces from logcat related to network stats API

As we can see in the attachment, there is some wlan traffic after the wifi is switched off, what is the reason of the traffic shown in costcontrol.

Comment 19

[Sarah Parsons]

How I was able to reproduce it 

1) Connect to WiFi network
2) Open "Cost control" and configure it to monitor WiFi usage.
3) Open browser and visit a site (i.e., http://mozqa.com/data/firefox/layout/mozilla.html).
4) Disconnect the current WiFi network (But WiFi icon in "notifications" still on)
5) Open cost control and observe WiFi values
6) Reset WiFi usage. Observe new value for wi-fi usage.

How I cannot reproduce the issue

 1) Connect to WiFi network
 2) Open "Cost control" and configure it to monitor WiFi usage.
 3) Open browser and visit a site (i.e., http://mozqa.com/data/firefox/layout/mozilla.html).
 4) Disconnect WiFi completely(verify WiFi blue icon is off in notification) and Use "adb shell netcfg" command to verify wlan is off
 5) Open cost control and observe WiFi values
 6) Reset WiFi usage. Observe new value for wi-fi usage.


(In reply to Robert Chira [:RobertC] from comment #17)
> I retested this on hamachi with the following build:
> Gaia      e61dc0019d9d6135d88ba15153c37f73a952567e
> Gecko     https://hg.mozilla.org/mozilla-central/rev/a10d0ba50f64
> BuildID   20140312160210
> Version   30.0a1
> ro.build.version.incremental=eng.tclxa.20131223.163538
> ro.build.date=Mon Dec 23 16:36:04 CST 2013
> 
> This issue is hard to rerpoduce manually, in our automated tests disabling
> the wifi is not done by going to settings. It is done with the help of the
> "disableWifi()" method found at
> https://github.com/mozilla-b2g/gaia/blob/master/tests/atoms/gaia_data_layer.
> js#L241
> 
> In the test between disabling the wifi and resetting the data usage I ran
> the "netcfg" shell command which always returned "wlan0    DOWN". When I
> observed the test failing with this issue I stopped it and ran "netcfg", but
> got the same result. Also, when looking in the notification bar I see the
> wifi set to OFF and the data usage is 0.00B.
> 
> Note: When this test fails, after resetting cost control the data usage is
> always 10.00 B.
> 
> Sarah - Can you provide some steps as to how you reproduced the issue and
> noticed that the wifi is still on?

Comment 20

[Jason Smith [:jsmith]]

Looks like the above analysis actually does conclude that this is the same as bug 838928.