981209 - Get rid of calls to DescribeScriptedCaller that are designed to test "Is script running?"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bobby Holley (:bholley)]

This is part of bug 979926. The idea is that DescribeScriptedCaller will become a lightway filename/line accessor for the most recent frame that the caller has access to, and won't be useful for any high-level decision-making.

One of the big cases of this is in NS_ScriptErrorReporter, which bug 981187 will hopefully sort out.

The other big one that I know of is in the rat's nest of nsXPCWrappedJSClass::CheckForException. That's pretty hairy stuff, but it's possible that it can all be massively simplified now that stuff should no longer be going through there.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Lots of chrome stuff will still go through nsXPCWrappedJSClass...

Comment 2

[Bobby Holley (:bholley)]

(In reply to Boris Zbarsky [:bz] from comment #1)
> Lots of chrome stuff will still go through nsXPCWrappedJSClass...

Yeah. But I'm hoping that the requirements there are a bit less touchy than they are for the web. Maybe I'm being overly-optimistic though.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Bug 1275704 removes the usage in nsXPCWrappedJSClass::CheckForException.  The usage in error reporting is long gone (went away with bug 1255817).

So I think once bug 1275704 lands we can declare this fixed.

Comment 4

[Jan de Mooij [:jandem]]

(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #3)
> So I think once bug 1275704 lands we can declare this fixed.