Closed
Bug 1255817
Opened 8 years ago
Closed 8 years ago
Make AutoJSAPI always take ownership of error reporting
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(8 files, 1 obsolete file)
13.75 KB,
text/plain
|
Details | |
31.66 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
1.35 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
2.63 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
4.82 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
2.51 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
6.23 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
7.72 KB,
text/plain
|
Details |
I audited all our callsites and will post the results in a bit once I file the bugs tracking things that need fixing. But once those things are fixed, we can do this.
Assignee | ||
Comment 1•8 years ago
|
||
Note that line numbers might be slightly off because of other code changes, of course.
Assignee | ||
Comment 2•8 years ago
|
||
Note that things that are particularly interesting in the audit are marked with "XXX" comments in that attachment.
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8729785 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8729786 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8729788 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8729789 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 7•8 years ago
|
||
Attachment #8729790 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 8•8 years ago
|
||
Attachment #8729791 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 9•8 years ago
|
||
Attachment #8729809 -
Flags: review?(bobbyholley)
Assignee | ||
Updated•8 years ago
|
Attachment #8729785 -
Attachment is obsolete: true
Attachment #8729785 -
Flags: review?(bobbyholley)
Updated•8 years ago
|
Attachment #8729809 -
Flags: review?(bobbyholley) → review+
Updated•8 years ago
|
Attachment #8729786 -
Flags: review?(bobbyholley) → review+
Updated•8 years ago
|
Attachment #8729788 -
Flags: review?(bobbyholley) → review+
Updated•8 years ago
|
Attachment #8729789 -
Flags: review?(bobbyholley) → review+
Comment 10•8 years ago
|
||
Comment on attachment 8729790 [details] [diff] [review] part 5. Remove the now-unused xpc::SystemErrorReporter Review of attachment 8729790 [details] [diff] [review]: ----------------------------------------------------------------- \o/ \o/ \o/
Attachment #8729790 -
Flags: review?(bobbyholley) → review+
Updated•8 years ago
|
Attachment #8729791 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 11•8 years ago
|
||
So I realized there are three more sources of AutoJSAPI that I had not audited yet: AutoSafeJSContext, AutoJSContext, ThreadSafeAutoJSContext (these last two only on mainthread when there is nothing on the JSContext stack). I think my plan is as follows: 1) Audit AutoSafeJSContext uses. I will attach that audit here. 2) Get rid of ThreadSafeAutoJSContext in favor of passing JSContext* directly. 3) Assume that any AutoJSContext consumer who is running when the JSContext stack is empty really does want to report the error, since there is nowhere else for it to go.
Assignee | ||
Comment 12•8 years ago
|
||
Comment 13•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/96449936b41a https://hg.mozilla.org/integration/mozilla-inbound/rev/a45a6cde6558 https://hg.mozilla.org/integration/mozilla-inbound/rev/870cb629e575 https://hg.mozilla.org/integration/mozilla-inbound/rev/564aabb49527 https://hg.mozilla.org/integration/mozilla-inbound/rev/b44267ae61b9 https://hg.mozilla.org/integration/mozilla-inbound/rev/1d07dab8a233
Comment 14•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/96449936b41a https://hg.mozilla.org/mozilla-central/rev/a45a6cde6558 https://hg.mozilla.org/mozilla-central/rev/870cb629e575 https://hg.mozilla.org/mozilla-central/rev/564aabb49527 https://hg.mozilla.org/mozilla-central/rev/b44267ae61b9 https://hg.mozilla.org/mozilla-central/rev/1d07dab8a233
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•