Remove DataContainerEvent dependency from Plugin crash handler

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla31
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Posted patch patchSplinter Review
No description provided.
Attachment #8387992 - Flags: review?(jst)
Attachment #8388014 - Flags: review?(standard8)
Comment on attachment 8388014 [details] [diff] [review]
Corresponding comm-central fix

Review of attachment 8388014 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #8388014 - Flags: review?(standard8) → review+
Jst, ping?
Comment on attachment 8387992 [details] [diff] [review]
patch

r=jst, but :johns should have a look at this as well, as he's been doing a bunch of work in this code.
Attachment #8387992 - Flags: review?(jst)
Attachment #8387992 - Flags: review?(jschoenick)
Attachment #8387992 - Flags: review+
Comment on attachment 8387992 [details] [diff] [review]
patch

Review of attachment 8387992 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/test/mochitest/test_crash_notify.xul
@@ -72,3 @@
>       "plugin crashed event has the right interface");
>  
> -  var minidumpID = aEvent.getData("minidumpID");

Was this test just broken before?
Attachment #8387992 - Flags: review?(jschoenick) → review+
(In reply to John Schoenick [:johns] from comment #5)
> > -  var minidumpID = aEvent.getData("minidumpID");
> 
> Was this test just broken before?

Yes. |isnot(minidumpID, "", "got a non-empty dump ID");| didn't catch this because a stringified null ("null") is not an empty string ("").
Now if the given property is not set, getProperty* will throw and the test will fail. Then it did fail, so I noticed the test error.
https://hg.mozilla.org/integration/mozilla-inbound/rev/70d66415ada6
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Whiteboard: c-c patch need to be landed as well
Attachment #8388014 - Flags: checkin?
Keywords: checkin-needed
Keywords: leave-open
Attachment #8388014 - Flags: checkin? → checkin+
https://hg.mozilla.org/comm-central/rev/15d8e9787b16
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: c-c patch need to be landed as well
Target Milestone: --- → mozilla31
Blocks: 1008925
You need to log in before you can comment on or make changes to this bug.