981237 - Remove DataContainerEvent dependency from Plugin crash handler

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Corresponding comm-central fix

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8388014 [details] [diff] [review]
Corresponding comm-central fix

Review of attachment 8388014 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 3

[Masatoshi Kimura [:emk]]

Jst, ping?

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 8387992 [details] [diff] [review]
patch

r=jst, but :johns should have a look at this as well, as he's been doing a bunch of work in this code.

Comment 5

[John Schoenick [:johns]]

Comment on attachment 8387992 [details] [diff] [review]
patch

Review of attachment 8387992 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/test/mochitest/test_crash_notify.xul
@@ -72,3 @@
>       "plugin crashed event has the right interface");
>  
> -  var minidumpID = aEvent.getData("minidumpID");

Was this test just broken before?

Comment 6

[Masatoshi Kimura [:emk]]

(In reply to John Schoenick [:johns] from comment #5)
> > -  var minidumpID = aEvent.getData("minidumpID");
> 
> Was this test just broken before?

Yes. |isnot(minidumpID, "", "got a non-empty dump ID");| didn't catch this because a stringified null ("null") is not an empty string ("").
Now if the given property is not set, getProperty* will throw and the test will fail. Then it did fail, so I noticed the test error.

Comment 7

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70d66415ada6

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70d66415ada6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/15d8e9787b16